From fe8e177d2e9d99bf4935d39e6bedf213ba3e0c34 Mon Sep 17 00:00:00 2001 From: julianfoo Date: Mon, 19 Jul 2021 22:22:28 +0800 Subject: [PATCH] FIX: Fixed get method calls to be compatible with Ruby 3 --- .ruby-version | 1 + lib/coingecko_ruby/client/coins.rb | 8 ++++---- lib/coingecko_ruby/client/derivatives.rb | 6 +++--- lib/coingecko_ruby/client/events.rb | 2 +- lib/coingecko_ruby/client/exchanges.rb | 8 ++++---- lib/coingecko_ruby/client/finance.rb | 4 ++-- lib/coingecko_ruby/client/indexes.rb | 4 ++-- lib/coingecko_ruby/client/infos.rb | 2 +- lib/coingecko_ruby/client/prices.rb | 12 ++++++------ 9 files changed, 24 insertions(+), 23 deletions(-) create mode 100644 .ruby-version diff --git a/.ruby-version b/.ruby-version new file mode 100644 index 0000000..860487c --- /dev/null +++ b/.ruby-version @@ -0,0 +1 @@ +2.7.1 diff --git a/lib/coingecko_ruby/client/coins.rb b/lib/coingecko_ruby/client/coins.rb index 63f349b..0b9c22b 100644 --- a/lib/coingecko_ruby/client/coins.rb +++ b/lib/coingecko_ruby/client/coins.rb @@ -22,7 +22,7 @@ module Coins # }, { # ] def coins_list(**options) - get 'coins/list', options + get 'coins/list', **options end # Fetches detailed current data for a coin. @@ -38,7 +38,7 @@ def coins_list(**options) # @example Fetch Bitcoin's current data. # client.coin('bitcoin') def coin(id, **options) - get "coins/#{id}", options + get "coins/#{id}", **options end # @deprecated Use {#coin} instead @@ -128,7 +128,7 @@ def get_coin_data(id:, options: {}) # }], # } def tickers(id, **options) - get "coins/#{id}/tickers", options + get "coins/#{id}/tickers", **options end # @deprecated Use {#tickers} instead @@ -216,7 +216,7 @@ def get_tickers(id:, options: {}) # } # ] def markets(ids, **options) - get 'coins/markets', { ids: ids, **options } + get 'coins/markets', ids: ids, **options end # @deprecated Use {#markets} instead diff --git a/lib/coingecko_ruby/client/derivatives.rb b/lib/coingecko_ruby/client/derivatives.rb index 7993fcc..27a570e 100644 --- a/lib/coingecko_ruby/client/derivatives.rb +++ b/lib/coingecko_ruby/client/derivatives.rb @@ -45,7 +45,7 @@ module Derivatives # }, # ] def derivatives(**options) - get 'derivatives', options + get 'derivatives', **options end # @deprecated Use {#derivatives} instead @@ -79,7 +79,7 @@ def get_derivatives(options: {}) # "url" => "https://www.binance.com/" # }] def derivative_exchanges(**options) - get 'derivatives/exchanges', options + get 'derivatives/exchanges', **options end # @deprecated Use {#derivative_exchanges} instead @@ -112,7 +112,7 @@ def get_derivative_exchanges(options: {}) # "url" => "https://www.binance.com/" # } def derivative_exchange(id, **options) - get "derivatives/exchanges/#{id}", options + get "derivatives/exchanges/#{id}", **options end # @deprecated Use {#derivative_exchange} instead diff --git a/lib/coingecko_ruby/client/events.rb b/lib/coingecko_ruby/client/events.rb index be73db6..8e45248 100644 --- a/lib/coingecko_ruby/client/events.rb +++ b/lib/coingecko_ruby/client/events.rb @@ -16,7 +16,7 @@ module Events # @example Get all upcoming events. # client.events(upcoming_events_only: true) def events(**options) - get 'events', options + get 'events', **options end # @deprecated Use {#events} instead diff --git a/lib/coingecko_ruby/client/exchanges.rb b/lib/coingecko_ruby/client/exchanges.rb index 99ccb1d..0c01ea5 100644 --- a/lib/coingecko_ruby/client/exchanges.rb +++ b/lib/coingecko_ruby/client/exchanges.rb @@ -26,7 +26,7 @@ module Exchanges # "trade_volume_24h_btc_normalized" => 982949.3975723931 # }] def exchanges(**options) - get 'exchanges', options + get 'exchanges', **options end # @deprecated Use {#exchanges} instead @@ -121,7 +121,7 @@ def get_exchanges_ids # }] # } def exchange_tickers(id, **options) - get "exchanges/#{id}/tickers", options + get "exchanges/#{id}/tickers", **options end # @deprecated Use {#exchange_tickers} instead @@ -157,7 +157,7 @@ def get_exchange_tickers(id:, options: {}) # }] # } def exchange_status(id, **options) - get "exchanges/#{id}/status_updates", options + get "exchanges/#{id}/status_updates", **options end # @deprecated Use {#exchange_status} instead @@ -181,7 +181,7 @@ def get_exchange_status_updates(id:, options: {}) # [1620557400000.0, "1042158.4333253484568599192332614201045319574863305612009609211497295171074087677404153278624"] # ] def exchange_volume(id, days: 7, **options) - get "exchanges/#{id}/volume_chart", { days: days, **options } + get "exchanges/#{id}/volume_chart", days: days, **options end # @deprecated Use {#exchange_volume} instead diff --git a/lib/coingecko_ruby/client/finance.rb b/lib/coingecko_ruby/client/finance.rb index 0fb1a7b..78f92df 100644 --- a/lib/coingecko_ruby/client/finance.rb +++ b/lib/coingecko_ruby/client/finance.rb @@ -35,7 +35,7 @@ module Finance # } # ] def finance_platforms(**options) - get 'finance_platforms', options + get 'finance_platforms', **options end # @deprecated Use {#finance_platforms} instead @@ -88,7 +88,7 @@ def get_finance_platforms(options: {}) # "redeem_at"=>0} # ] def finance_products(**options) - get 'finance_products', options + get 'finance_products', **options end # @deprecated Use {#finance_products} instead diff --git a/lib/coingecko_ruby/client/indexes.rb b/lib/coingecko_ruby/client/indexes.rb index 5124550..99b804f 100644 --- a/lib/coingecko_ruby/client/indexes.rb +++ b/lib/coingecko_ruby/client/indexes.rb @@ -29,7 +29,7 @@ module Indexes # "is_multi_asset_composite"=>false} # ] def indexes(**options) - get 'indexes', options + get 'indexes', **options end # @deprecated Use {#indexes} instead @@ -76,7 +76,7 @@ def get_indexes_ids # "is_multi_asset_composite"=>false # } def indexes_by_market_and_coin(market_id, coin_id, **options) - get "indexes/#{market_id}/#{coin_id}", options + get "indexes/#{market_id}/#{coin_id}", **options end # @deprecated Use {#indexes_by_market_and_coin} instead diff --git a/lib/coingecko_ruby/client/infos.rb b/lib/coingecko_ruby/client/infos.rb index 0fa2720..7eb727c 100644 --- a/lib/coingecko_ruby/client/infos.rb +++ b/lib/coingecko_ruby/client/infos.rb @@ -163,7 +163,7 @@ def get_trending_searches # }] # } def status_updates(**options) - get 'status_updates', options + get 'status_updates', **options end def get_status_updates(options: {}) diff --git a/lib/coingecko_ruby/client/prices.rb b/lib/coingecko_ruby/client/prices.rb index 487bc97..8df734c 100644 --- a/lib/coingecko_ruby/client/prices.rb +++ b/lib/coingecko_ruby/client/prices.rb @@ -34,7 +34,7 @@ module Prices def price(ids, currency: 'usd', **options) ids = ids.join(',') if ids.is_a? Array currency = currency.join(',') if currency.is_a? Array - get 'simple/price', { ids: ids, vs_currencies: currency, **options } + get 'simple/price', ids: ids, vs_currencies: currency, **options end # @see Alias for {#price} @@ -122,7 +122,7 @@ def get_price(id:, currency: 'usd', options: {}) def historical_price(id, date:, **options) date = Time.now.strftime('%d-%m-%Y') if date.nil? - get "coins/#{id}/history", { date: date, **options } + get "coins/#{id}/history", date: date, **options end # @deprecated Use {#historical_price} instead @@ -158,7 +158,7 @@ def get_historical_price_on_date(id:, date:) # ] # } def minutely_historical_price(id, currency: 'usd', **options) - get "coins/#{id}/market_chart", { vs_currency: currency, days: 1, **options } + get "coins/#{id}/market_chart", vs_currency: currency, days: 1, **options end # @deprecated Use {#minutely_historical_price} instead @@ -195,7 +195,7 @@ def get_minutely_historical_prices(id:, currency: 'usd') def hourly_historical_price(id, currency: 'usd', days: 7, **options) return daily_historical_price(id, currrency: currency, days: days) if days > 90 - get "coins/#{id}/market_chart", { vs_currency: currency, days: days, **options } + get "coins/#{id}/market_chart", vs_currency: currency, days: days, **options end # @deprecated Use {#hourly_historical_price} instead @@ -229,7 +229,7 @@ def get_hourly_historical_prices(id:, days:, currency: 'usd') # ] # } def daily_historical_price(id, currency: 'usd', days: 7, **options) - get "coins/#{id}/market_chart", { vs_currency: currency, days: days, interval: 'daily', **options } + get "coins/#{id}/market_chart", vs_currency: currency, days: days, interval: 'daily', **options end # @deprecated Use {#daily_historical_price} instead @@ -256,7 +256,7 @@ def get_daily_historical_prices(id:, days:, currency: 'usd') # [1620576000000, 57956.7, 57956.7, 56636.68, 57302.22], # ] def ohlc(id, currency: 'usd', days: 7, **options) - get "coins/#{id}/ohlc", { vs_currency: currency, days: days, **options } + get "coins/#{id}/ohlc", vs_currency: currency, days: days, **options end # @deprecated Use {#ohlc} instead