Add Map & Set to useLocalStorage control #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecsFarias
commented
Apr 10, 2023
Comment on lines
+35
to
+45
| const parsed = parseJSON(item) as T | ||
|
|
||
| //considering that the initial value is a Map, convert object to map | ||
| if(initialValue instanceof Map) { | ||
| return new Map(Object.entries(parsed as Object)) as T | ||
| } | ||
|
|
||
| //considering that the initial value is a Set, convert the array to set | ||
| if(initialValue instanceof Set) { | ||
| return new Set(parsed as Array<any>) as T | ||
| } |
There was a problem hiding this comment.
Gonna write this here because I think it is more like to be a question on this pr than a part of it's description.
'Why not put this Map and Set creation logic inside parseJSON function ? "
I did this way because I think that it was no good to add a new parameter to parseJSON function just to say that it would be a Map or Set. Considering that is no more than this 2 instance checks I think that it would have no problem to stay this way, but, open for tips and discussions !
|
Hi, very usefull function |
|
finally someone did it 🙌🏻 |
|
Hi you all, good feature indeed. As the PR's base branch is outdated, I moved this code there #439. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> enable useLocalStorage hook to work with Map and Set
-> check instance types of
initialValueto work with return type onreadValue-> create
stringifyfunction to work separately with type checking and string buildissue: #308