Skip to content

Commit cfd5845

Browse files
committed
Remove OpenRewrite from build
We used OpenRewrite as a migration aid when bumping the Java baseline from 8 to 17. After evaluating its use for ongoing static analysis, it doesn't provide enough added value to justify maintaining configuration etc. for another tool. In #4748, additional Checkstyle rules will be enabled instead which address almost all issues found by OpenRewrite's recipes. Moreover, openrewrite/rewrite-gradle-plugin#212 prevents us from using it in our build.
1 parent 4cd188e commit cfd5845

File tree

3 files changed

+0
-14
lines changed

3 files changed

+0
-14
lines changed

gradle/libs.versions.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ mockito-core = { module = "org.mockito:mockito-core" }
6161
mockito-junit-jupiter = { module = "org.mockito:mockito-junit-jupiter" }
6262
nohttp-checkstyle = { module = "io.spring.nohttp:nohttp-checkstyle", version = "0.0.11" }
6363
nullaway = { module = "com.uber.nullaway:nullaway", version = "0.12.7" }
64-
openrewrite-recipe-bom = { module = "org.openrewrite.recipe:rewrite-recipe-bom", version = "3.11.1" }
6564
opentest4j = { module = "org.opentest4j:opentest4j", version.ref = "opentest4j" }
6665
openTestReporting-cli = { module = "org.opentest4j.reporting:open-test-reporting-cli", version.ref = "openTestReporting" }
6766
openTestReporting-events = { module = "org.opentest4j.reporting:open-test-reporting-events", version.ref = "openTestReporting" }
@@ -106,7 +105,6 @@ jreleaser = { id = "org.jreleaser", version = "1.19.0" }
106105
# check if workaround in gradle.properties can be removed when updating
107106
kotlin = { id = "org.jetbrains.kotlin.jvm", version = "2.2.0" }
108107
nullaway = { id = "net.ltgt.nullaway", version = "2.2.0" }
109-
openrewrite = { id = "org.openrewrite.rewrite", version = "7.10.0" }
110108
plantuml = { id = "io.freefair.plantuml", version = "8.14" }
111109
shadow = { id = "com.gradleup.shadow", version = "8.3.8" }
112110
spotless = { id = "com.diffplug.spotless", version = "7.1.0" }

gradle/plugins/common/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ dependencies {
1616
implementation(libs.plugins.foojayResolver.markerCoordinates)
1717
implementation(libs.plugins.jmh.markerCoordinates)
1818
implementation(libs.plugins.nullaway.markerCoordinates)
19-
implementation(libs.plugins.openrewrite.markerCoordinates)
2019
implementation(libs.plugins.shadow.markerCoordinates)
2120
implementation(libs.plugins.spotless.markerCoordinates)
2221
}

gradle/plugins/common/src/main/kotlin/junitbuild.java-library-conventions.gradle.kts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
2-
import junitbuild.extensions.dependencyFromLibs
32
import junitbuild.extensions.isSnapshot
43
import org.gradle.plugins.ide.eclipse.model.Classpath
54
import org.gradle.plugins.ide.eclipse.model.Library
@@ -14,16 +13,6 @@ plugins {
1413
id("junitbuild.build-parameters")
1514
id("junitbuild.checkstyle-conventions")
1615
id("junitbuild.jacoco-java-conventions")
17-
id("org.openrewrite.rewrite")
18-
}
19-
20-
rewrite {
21-
activeRecipe("org.openrewrite.java.migrate.UpgradeToJava17")
22-
}
23-
24-
dependencies {
25-
rewrite(platform(dependencyFromLibs("openrewrite-recipe-bom")))
26-
rewrite("org.openrewrite.recipe:rewrite-migrate-java")
2716
}
2817

2918
val mavenizedProjects: List<Project> by rootProject.extra

0 commit comments

Comments
 (0)