-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Allow @ResourceLock on @ClassTemplate classes
#5176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcphilipp
merged 4 commits into
junit-team:main
from
raccoonback:5155-fix-exclusive-resources-for-class-template
Dec 7, 2025
Merged
Allow @ResourceLock on @ClassTemplate classes
#5176
marcphilipp
merged 4 commits into
junit-team:main
from
raccoonback:5155-fix-exclusive-resources-for-class-template
Dec 7, 2025
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes junit-team#5155 Signed-off-by: raccoonback <kosb15@naver.com>
Contributor
Author
|
@marcphilipp |
marcphilipp
requested changes
Nov 30, 2025
jupiter-tests/src/test/java/org/junit/jupiter/engine/ClassTemplateInvocationTests.java
Show resolved
Hide resolved
Signed-off-by: raccoonback <kosb15@naver.com>
659c7ea to
ea7cfc8
Compare
Contributor
Author
|
@marcphilipp |
Contributor
Author
|
@marcphilipp |
@ResourceLock on @ClassTemplate classes
marcphilipp
approved these changes
Dec 7, 2025
✅ All tests passed ✅Test Summary
🏷️ Commit: 52b6a09 Test FailureSeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded (:jupiter-tests:test in macOS) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5155
This PR enables the use of
@ResourceLockon classes annotated with@ClassTemplate.Background
Currently, applying
@ResourceLockto a@ClassTemplateclass results in the following failure:This happens because
ClassTemplateInvocationTestDescriptor#getExclusiveResources()returns a non-empty set, causing the invocation descriptor to report exclusive resources even though the enclosingClassTemplateTestDescriptoralready collects and exposes them at the class level.Summary of Changes
Override
ClassTemplateInvocationTestDescriptor#getExclusiveResources()to always return an empty set.ClassTemplateTestDescriptor, so the invocation descriptor should not contribute additional exclusive resources.Add a dedicated test
classTemplateWithResourceLockExecutesSuccessfully()to verify that:@ClassTemplateclass annotated with@ResourceLockexecutes successfully.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations