Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: export KhanAnswerTypes from khan perseus #14

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Kim716
Copy link

@Kim716 Kim716 commented Mar 26, 2024

Pull Request Title 請加上 prefix,e.g. New:/Fix:/Change:/Refactor:/Chore:/Test:/Doc: ...

Notion Link: https://www.notion.so/junyiacademy/Input-number-Widget-6cafdae735534265a65dfd90f217c8a5?pvs=4

Introduction

請說明此 Pull Request 的目的

  • InputNumber widget 會用到 KhanAnswerTypes

How to verify

請說明如何驗證此 Pull Request 的改動可以達成目的(或是做過哪些驗證)

  • 可以在主站 repo 使用到 perseus 的 KhanAnswerTypes (export 時有改名為 KhanAnswerTypesUtils,因為 types 結尾容易誤會是 type)

@Kim716 Kim716 self-assigned this Mar 26, 2024
@@ -1,6 +1,6 @@
{
"name": "@junyiacademy/perseus-core",
"version": "1.0.29",
"version": "1.0.30",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後續 forced push 只有補版本號 1.0.29 -> 1.0.30

@Kim716 Kim716 merged commit 6a46baf into main Mar 26, 2024
@Kim716 Kim716 added the 🔧 publish-npm Add this tag will publish perseus-core to npm label Mar 26, 2024
@Kim716 Kim716 deleted the feat/export-answer-types branch April 1, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 publish-npm Add this tag will publish perseus-core to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants