Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions for .lsp_symlink workaround #846

Merged
merged 6 commits into from
Sep 3, 2022

Conversation

slavistan
Copy link
Contributor

@krassowski As per #828, here's a draft.

I've left the unix-only part in the instructions. I am, however, unsure about why this wouldn't affect Windows users. Do you have any more insight on this?

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch slavistan/jupyterlab-lsp/master

@krassowski
Copy link
Member

I am, however, unsure about why this wouldn't affect Windows users.

Windows users would need to enable Developer Mode in order to create symlinks and I do not have bandwidth to test if this workaround works on Windows correctly, hence the readme does not encourage it.

I added a link to a plan for a better solution which would not require a symlink and allow fine-grained access control: #850.

README.md Outdated Show resolved Hide resolved
Co-authored-by: stan <hdstansen@gmail.com>
@krassowski krassowski merged commit 2a524df into jupyter-lsp:master Sep 3, 2022
@krassowski
Copy link
Member

Thank you @slavistan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants