Prepare extension and CI for release candidate #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
which block diagnostics from being shown in file editor due to CM6 document mismatch due to delay by one version, and seems to work fine without it in both editor and notebook
and a workaround of sending the update again because the connection manager is now a separate plugin which starts and can sent initial configuration before our plugin gets to setting transformation. Also use promise delegate over custom method to simplify code.
as this is the default for `Wait Until Page Contains Element`
which is what was causing the remaining tests to be flaky
krassowski
commented
Sep 11, 2023
krassowski
changed the title
Prior to this commit the positions would be always resolved with respect to the root document because virtual document was being taken from adapter using `virtualPositionToRootPosition` func which is error prone as the assumption of virtual document == root document is not obvious; this function was removed. To make the fixes work, a workaround for foreign document created in inherited classes always having the usptream class was added; the issue was reported in jupyterlab/jupyterlab#15126
Notably, we no longer adjust start/end position based on individual items because that was not predictable; instead we revert the logic and populate insert text as needed to match start/end. We only change end to equal start if there are absolutely no prefix matches, which is required because otherwise everything would be filtered out.
selecting `ValueError` on `va` would produce `valueError`.
|
This is down to 15 failing tests, 4 of which are upstream issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #961
Code changes
New and renamed keywords:
Type comments are no more.
Removed no longer needed CI pins 🎉
Remaining completer bugs:
processedItemsCacheresolverequestUser-facing changes
Backwards-incompatible changes
None