Separate eventloop init/start from webapp init/start #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidartf
reviewed
Nov 29, 2019
Member
vidartf
left a comment
vidartf
left a comment
There was a problem hiding this comment.
I'm not sure I have enough of a full-picture to say if this is a good idea or not (the PR is simply presented as a solution to a problem related to testing, but the problem itself is not clear to me). Assuming it makes sense, I've made some comments on the implementation below.
jupyter_server/serverapp.py
Outdated
| pc.start() | ||
|
|
||
| def init_httpserver(self): | ||
| """initialize tornado httpserver""" |
Member
There was a problem hiding this comment.
I would add a note here that init_webapp must be called before this in order to ensure that multiple config/setting variables get initialized and set up. It should also specify what the alternative is (e.g. if you pass new_httpserver=False, then how is self.http_server supposed to be set?).
Member
Author
|
Closing because this logic was merged in #152 |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* add a launch_timeout trait to kernel provisioner * Bump to 0.12.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the logic for initializing+starting the eventloop from the initializing+starting the main application. This is particularly helpful for writing unit tests.
This enables us to replace the
HttpServerinServerAppwith test server like pytest-tornado'shttpserverfixture. For an example of such tests, see Zsailer/jupyter_server_tests.