Skip to content

Enforce Python 3.6 in setup.py to support JKM #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echarles merged 5 commits into from
Dec 3, 2019
Merged

Enforce Python 3.6 in setup.py to support JKM #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83d89e9
enforce 3.6 in setup.py
echarles Dec 2, 2019
5523687
update travis and appveyor to run py 3.6, 3.7. and 3.8
echarles Dec 2, 2019
48ad76e
Merge branch 'master' into py-3.6
echarles Dec 3, 2019
747e614
trigger build
echarles Dec 3, 2019
f315576
disable coverage to avoid systematic failure
echarles Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ cache:
directories:
- $HOME/.cache/bower
- $HOME/.cache/pip
python:
- 3.6

env:
global:
- PATH=$TRAVIS_BUILD_DIR/pandoc:$PATH
Expand All @@ -28,7 +25,6 @@ install:
- pip freeze
- wget https://github.com/jgm/pandoc/releases/download/1.19.1/pandoc-1.19.1-1-amd64.deb && sudo dpkg -i pandoc-1.19.1-1-amd64.deb


script:
- jupyter kernelspec list
- |
Expand All @@ -41,7 +37,7 @@ script:
else
true
fi
- 'if [[ $GROUP == python ]]; then nosetests -v --with-coverage --cover-package=jupyter_server jupyter_server; fi'
- 'if [[ $GROUP == python ]]; then nosetests -v jupyter_server; fi'
- |
if [[ $GROUP == docs ]]; then
EXIT_STATUS=0
Expand All @@ -54,17 +50,20 @@ script:
exit $EXIT_STATUS
fi


matrix:
include:
- python: 3.5
- python: 3.6
env: GROUP=python
- python: 3.7
env: GROUP=python
- python: 3.8
env: GROUP=python
- python: 3.6
env: GROUP=docs
- python: 3.7
env: GROUP=docs
- python: 3.8
env: GROUP=docs

after_success:
- codecov
6 changes: 5 additions & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ environment:
matrix:
- CONDA_PY: 36
CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
- CONDA_PY: 37
CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
- CONDA_PY: 38
CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"

platform:
- x64
Expand All @@ -21,4 +25,4 @@ install:
- cmd: pip install .[test]

test_script:
- nosetests -v jupyter_server --exclude-dir notebook\tests\selenium
- nosetests -v jupyter_server --exclude-dir jupyter_server\tests\selenium
7 changes: 3 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
name = "jupyter_server"

# Minimal Python version sanity check
if sys.version_info < (3,5):
error = "ERROR: %s requires Python version 3.5 or above." % name
if sys.version_info < (3,6):
error = "ERROR: %s requires Python version 3.6 or above." % name
print(error, file=sys.stderr)
sys.exit(1)

Expand Down Expand Up @@ -67,7 +67,6 @@
'License :: OSI Approved :: BSD License',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
],
Expand Down Expand Up @@ -95,7 +94,7 @@
'nbval', 'nose-exclude', 'selenium', 'pytest', 'pytest-cov'],
'test:sys_platform == "win32"': ['nose-exclude'],
},
python_requires = '>=3.5',
python_requires = '>=3.6',
entry_points = {
'console_scripts': [
'jupyter-server = jupyter_server.serverapp:main',
Expand Down