From f2c0c68f7e748d47c95bf09d354f3f7fd3ea3c79 Mon Sep 17 00:00:00 2001 From: Talley Lambert Date: Sun, 8 Oct 2023 20:21:56 -0400 Subject: [PATCH] clarify fontawesome naming --- docs/source/examples/Widget List.ipynb | 16 +++++++++++----- .../ipywidgets/widgets/widget_selection.py | 4 ++-- ui-tests/tests/notebooks/widgets.ipynb | 4 ++-- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/docs/source/examples/Widget List.ipynb b/docs/source/examples/Widget List.ipynb index 57164f6015..812594760d 100644 --- a/docs/source/examples/Widget List.ipynb +++ b/docs/source/examples/Widget List.ipynb @@ -3,7 +3,9 @@ { "cell_type": "markdown", "metadata": { - "tags": ["remove-cell"] + "tags": [ + "remove-cell" + ] }, "source": [ "[Index](Index.ipynb) - [Back](Widget%20Basics.ipynb) - [Next](Output%20Widget.ipynb)" @@ -20,7 +22,9 @@ "cell_type": "code", "execution_count": null, "metadata": { - "tags": ["remove-cell"] + "tags": [ + "remove-cell" + ] }, "outputs": [], "source": [ @@ -415,7 +419,7 @@ " disabled=False,\n", " button_style='', # 'success', 'info', 'warning', 'danger' or ''\n", " tooltip='Description',\n", - " icon='check' # (FontAwesome names without the `fa-` prefix)\n", + " icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n", ")" ] }, @@ -931,7 +935,7 @@ " disabled=False,\n", " button_style='', # 'success', 'info', 'warning', 'danger' or ''\n", " tooltip='Click me',\n", - " icon='check' # (FontAwesome names without the `fa-` prefix)\n", + " icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n", ")\n", "button" ] @@ -1548,7 +1552,9 @@ { "cell_type": "markdown", "metadata": { - "tags": ["remove-cell"] + "tags": [ + "remove-cell" + ] }, "source": [ "[Index](Index.ipynb) - [Back](Widget%20Basics.ipynb) - [Next](Output%20Widget.ipynb)" diff --git a/python/ipywidgets/ipywidgets/widgets/widget_selection.py b/python/ipywidgets/ipywidgets/widgets/widget_selection.py index d81a779b96..0b1a43c740 100644 --- a/python/ipywidgets/ipywidgets/widgets/widget_selection.py +++ b/python/ipywidgets/ipywidgets/widgets/widget_selection.py @@ -429,7 +429,7 @@ class ToggleButtons(_Selection): icons: list Icons to show on the buttons. This must be the name - of a font-awesome icon. See `http://fontawesome.io/icons/` + of a (v5) font-awesome icon. See `https://fontawesome.com/v5/search` for a list of icons. button_style: str @@ -443,7 +443,7 @@ class ToggleButtons(_Selection): _model_name = Unicode('ToggleButtonsModel').tag(sync=True) tooltips = TypedTuple(Unicode(), help="Tooltips for each button.").tag(sync=True) - icons = TypedTuple(Unicode(), help="Icons names for each button (FontAwesome names without the fa- prefix).").tag(sync=True) + icons = TypedTuple(Unicode(), help="Icons names for each button (FontAwesome v5 names without the fa- prefix).").tag(sync=True) style = InstanceDict(ToggleButtonsStyle).tag(sync=True, **widget_serialization) button_style = CaselessStrEnum( diff --git a/ui-tests/tests/notebooks/widgets.ipynb b/ui-tests/tests/notebooks/widgets.ipynb index b5317deb9a..ac5469574e 100644 --- a/ui-tests/tests/notebooks/widgets.ipynb +++ b/ui-tests/tests/notebooks/widgets.ipynb @@ -222,7 +222,7 @@ " disabled=False,\n", " button_style='', # 'success', 'info', 'warning', 'danger' or ''\n", " tooltip='Description',\n", - " icon='check' # (FontAwesome names without the `fa-` prefix)\n", + " icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n", ")" ] }, @@ -516,7 +516,7 @@ " disabled=False,\n", " button_style='', # 'success', 'info', 'warning', 'danger' or ''\n", " tooltip='Click me',\n", - " icon='check' # (FontAwesome names without the `fa-` prefix)\n", + " icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n", ")\n", "button" ]