From a74688eda4340a949caa9ea4466e839b9a8e9748 Mon Sep 17 00:00:00 2001
From: anutosh491 <andersonbhat491@gmail.com>
Date: Sat, 29 Jun 2024 14:03:50 +0530
Subject: [PATCH] Fix notify socket listener calls

---
 include/xeus-zmq/xclient_zmq.hpp |  4 ----
 src/client/xclient_zmq.cpp       | 15 ---------------
 src/client/xclient_zmq_impl.hpp  | 10 +++++-----
 3 files changed, 5 insertions(+), 24 deletions(-)

diff --git a/include/xeus-zmq/xclient_zmq.hpp b/include/xeus-zmq/xclient_zmq.hpp
index 908c06d..6190cc9 100644
--- a/include/xeus-zmq/xclient_zmq.hpp
+++ b/include/xeus-zmq/xclient_zmq.hpp
@@ -58,10 +58,6 @@ namespace xeus
         void wait_for_message();
 
     private:
-
-        void notify_shell_listener(xmessage msg);
-        void notify_control_listener(xmessage msg);
-        void notify_iopub_listener(xpub_message msg);
         
         std::unique_ptr<xclient_zmq_impl> p_client_impl;
     };
diff --git a/src/client/xclient_zmq.cpp b/src/client/xclient_zmq.cpp
index 365e395..06e3e78 100644
--- a/src/client/xclient_zmq.cpp
+++ b/src/client/xclient_zmq.cpp
@@ -91,21 +91,6 @@ namespace xeus
     {
         p_client_impl->wait_for_message();
     }
-
-    void xclient_zmq::notify_shell_listener(xmessage msg)
-    {
-        p_client_impl->notify_shell_listener(std::move(msg));
-    }
-
-    void xclient_zmq::notify_control_listener(xmessage msg)
-    {
-        p_client_impl->notify_control_listener(std::move(msg));
-    }
-
-    void xclient_zmq::notify_iopub_listener(xpub_message msg)
-    {
-        p_client_impl->notify_iopub_listener(std::move(msg));
-    }
     
     std::unique_ptr<xclient_zmq> make_xclient_zmq(xcontext& context,
                                                 const xconfiguration& config,
diff --git a/src/client/xclient_zmq_impl.hpp b/src/client/xclient_zmq_impl.hpp
index cc96935..4921137 100644
--- a/src/client/xclient_zmq_impl.hpp
+++ b/src/client/xclient_zmq_impl.hpp
@@ -69,11 +69,6 @@ namespace xeus
         void connect();
         void stop_channels();
 
-        void notify_shell_listener(xmessage msg);
-        void notify_control_listener(xmessage msg);
-        void notify_iopub_listener(xpub_message msg);
-        void notify_kernel_dead(bool status);
-
         void wait_for_message();
         void start();
 
@@ -86,6 +81,11 @@ namespace xeus
         void start_heartbeat_thread();
         void poll(long timeout);
 
+        void notify_shell_listener(xmessage msg);
+        void notify_control_listener(xmessage msg);
+        void notify_iopub_listener(xpub_message msg);
+        void notify_kernel_dead(bool status);
+
         using authentication_ptr = std::unique_ptr<xauthentication>;
         authentication_ptr p_auth;