updates

jupyter-xeus · Mar 20, 2024 · 36592d5 · 36592d5
1 parent 6b2db9c
commit 36592d5
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/include/xeus/xinterpreter.hpp b/include/xeus/xinterpreter.hpp
@@ -42,7 +42,7 @@ namespace xeus
 
         void configure();
 
-        nl::json execute_request( xexecute_request_context context,
+        void execute_request( xexecute_request_context context,
                                  const std::string& code,
                                  bool silent,
                                  bool store_history,
@@ -101,7 +101,7 @@ namespace xeus
 
         virtual void configure_impl() = 0;
 
-        virtual nl::json execute_request_impl(xexecute_request_context request_context,
+        virtual void execute_request_impl(xexecute_request_context request_context,
                                               int execution_counter,
                                               const std::string& code,
                                               bool silent,

diff --git a/src/xinterpreter.cpp b/src/xinterpreter.cpp
@@ -29,7 +29,7 @@ namespace xeus
         configure_impl();
     }
 
-    nl::json xinterpreter::execute_request(xexecute_request_context context,
+    void xinterpreter::execute_request(xexecute_request_context context,
                                            const std::string& code,
                                            bool silent,
                                            bool store_history,
@@ -42,14 +42,14 @@ namespace xeus
             publish_execution_input(context, code, m_execution_count);
         }
 
-        nl::json reply = execute_request_impl(
+        execute_request_impl(
             std::move(context),
             m_execution_count, code, silent,
             store_history, user_expressions, allow_stdin
         );
 
-        reply["execution_count"] = m_execution_count;
-        return reply;
+        // reply["execution_count"] = m_execution_count;
+        // return reply;
     }
 
     nl::json xinterpreter::complete_request(const std::string& code, int cursor_pos)

diff --git a/src/xmock_interpreter.hpp b/src/xmock_interpreter.hpp
@@ -38,7 +38,7 @@ namespace xeus
         {
         }
 
-        nl::json execute_request_impl(xexecute_request_context request_context,
+        void execute_request_impl(xexecute_request_context request_context,
                                     int /*execution_counter*/,
                                    const std::string& /*code*/,
                                    bool /*silent*/,

diff --git a/test/xmock_interpreter.cpp b/test/xmock_interpreter.cpp
@@ -29,7 +29,7 @@ namespace xeus
         using function_type = std::function<void(xeus::xcomm&&, const xeus::xmessage&)>;
     }
 
-    nl::json xmock_interpreter::execute_request_impl(xexecute_request_context request_context,
+    void xmock_interpreter::execute_request_impl(xexecute_request_context request_context,
                                                      int execution_counter,
                                                      const std::string& code,
                                                      bool /* silent */,

diff --git a/test/xmock_interpreter.hpp b/test/xmock_interpreter.hpp
@@ -25,7 +25,7 @@ namespace xeus
 
         void configure_impl() override;
 
-        nl::json execute_request_impl(xexecute_request_context request_context,
+        void execute_request_impl(xexecute_request_context request_context,
                                       int execution_counter,
                                       const std::string& code,
                                       bool silent,