Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use another repo for prettier pre-commit #2180

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mathbunnyru
Copy link
Member

Describe your changes

prettier/prettier#15742

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru mathbunnyru merged commit 976fbab into jupyter:main Dec 5, 2024
3 checks passed
@mathbunnyru
Copy link
Member Author

Merged this, seems to work fine, and it will stay up-to-date.

@manics
Copy link
Contributor

manics commented Dec 5, 2024

Thanks for finding this, it's been bothering me for a while in other repos 😃

@mathbunnyru
Copy link
Member Author

Thanks for finding this, it's been bothering me for a while in other repos 😃

Glad to help, it has been bothering me as well 🙂

Note: this is not an official way to use prettier as a pre-commit hook, but there is no longer an official way at all (the official repo was archived).
But I consider the fork to be good enough and I don't expect any problems.
If prettier or pre-commit decide to implement an official way of using one with another, I will of course switch to it.

@mathbunnyru
Copy link
Member Author

Btw, the issue with having node_modules/ in every repo with this hook seems to be fixed: rbubley/mirrors-prettier#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants