Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update R version to 3.3* in r-notebook and datascience-notebook #238

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

poplav
Copy link
Contributor

@poplav poplav commented Jul 13, 2016

No description provided.

@parente
Copy link
Member

parente commented Jul 13, 2016

Thanks @poplav . I'm curious to see how many of the packages work with R 3.3. :)

@poplav poplav force-pushed the bump_r_version branch 2 times, most recently from 005bff7 to 153c39a Compare July 13, 2016 20:09
@poplav
Copy link
Contributor Author

poplav commented Jul 14, 2016

Just realized there is the datascience-notebook as well [hand over face]. I'll update there as well.

@poplav poplav changed the title Update R version to 3.3* in r-notebook. Update R version to 3.3* in r-notebook and datascience-notebook Jul 14, 2016
@poplav poplav closed this Jul 14, 2016
@poplav poplav reopened this Jul 14, 2016
@poplav poplav closed this Jul 14, 2016
@poplav poplav reopened this Jul 14, 2016
@parente
Copy link
Member

parente commented Jul 14, 2016

@poplav No worries. I clearly don't have all the places nailed down in my mind either!

@poplav
Copy link
Contributor Author

poplav commented Jul 14, 2016

I am seeing #210. I need to verify it is not a result of these changes, so hold off on merging please.

@poplav
Copy link
Contributor Author

poplav commented Jul 14, 2016

It looks like 2485724a08c9 reintroduced #210 making libjpeg v9. Noting this is then not attributed to the recent R upgrades.

@parente
Copy link
Member

parente commented Jul 14, 2016

Thanks for tracking that down. I'm going to do one last check on the all-spark-notebook vs datascience-notebook for the tag you mention. I'm wondering if the R problem only exists in one and not the other because of the libs that are touched by other conda actions.

@poplav
Copy link
Contributor Author

poplav commented Jul 14, 2016

I did see that the fix mentioned in #210:

echo "jpeg 8*" >> /opt/conda/conda-meta/pinned
conda update --all -y

does work after the image is built. In my case I could run this in the dev_image step of declarative widgets, but that would not be optimal/time consuming

@parente
Copy link
Member

parente commented Jul 14, 2016

Nah. Don't fix it in your build. I'm looking into how to fix it in the main images.

@parente parente merged commit 97a5071 into jupyter:master Jul 15, 2016
@parente
Copy link
Member

parente commented Jul 15, 2016

Pushed 97a5071c5775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants