Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use simpler isoparse from dateutil to parse ISO-8601 timestamps #1032

Merged
merged 1 commit into from
Sep 17, 2024
Merged

use simpler isoparse from dateutil to parse ISO-8601 timestamps #1032

merged 1 commit into from
Sep 17, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 8, 2024

avoids more complex behavior of general parser, which we don't need since we are already specifying the general format spec as ISO-8601. Also, the general parse_date behavior seems to be vulnerable to problems:

@minrk minrk added the bug label Aug 8, 2024
@minrk minrk mentioned this pull request Aug 8, 2024
Closed
@minrk
use simpler isoparse from dateutil to parse ISO8601 timestamps
c97a2d6 
avoids more complex behavior of general parser, which we don't need
since we are already specifying the general format spec
@minrk minrk enabled auto-merge (squash) September 17, 2024 08:28
@minrk minrk merged commit 7716291 into jupyter:main Sep 17, 2024
30 of 31 checks passed
@minrk minrk deleted the isoparse branch September 17, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@minrk