From b92dd28b60c828211a5f126c8676c3ae05b5ebd2 Mon Sep 17 00:00:00 2001 From: Grant Nestor Date: Thu, 26 Oct 2017 10:33:20 -0700 Subject: [PATCH 1/3] Add more border width to CodeMirror cursor --- notebook/static/notebook/less/codemirror.less | 3 +++ 1 file changed, 3 insertions(+) diff --git a/notebook/static/notebook/less/codemirror.less b/notebook/static/notebook/less/codemirror.less index 37ca1db75a..8576bc4e59 100644 --- a/notebook/static/notebook/less/codemirror.less +++ b/notebook/static/notebook/less/codemirror.less @@ -52,3 +52,6 @@ .border-radius(0) } +.CodeMirror-cursor { + border-left: 1.2px solid black; +} From 0fe8ee191aa223214a3953237709dc40f9b137b1 Mon Sep 17 00:00:00 2001 From: Grant Nestor Date: Thu, 26 Oct 2017 13:31:14 -0700 Subject: [PATCH 2/3] Add media queries as proxy for zoom levels --- notebook/static/notebook/less/codemirror.less | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/notebook/static/notebook/less/codemirror.less b/notebook/static/notebook/less/codemirror.less index 8576bc4e59..0de5ebe605 100644 --- a/notebook/static/notebook/less/codemirror.less +++ b/notebook/static/notebook/less/codemirror.less @@ -53,5 +53,19 @@ } .CodeMirror-cursor { - border-left: 1.2px solid black; + border-left: 1.4px solid black; +} + +// When zoomed out 67% and 33% +@media screen and (min-width: 2138px) and (max-width: 4319px) { + .CodeMirror-cursor { + border-left: 2px solid black; + } +} + +// When zoomed out less than 33% +@media screen and (min-width: 4320px) { + .CodeMirror-cursor { + border-left: 4px solid black; + } } From 817f541be4ec2f5525ccdfe59b92f444781157a5 Mon Sep 17 00:00:00 2001 From: Grant Nestor Date: Thu, 26 Oct 2017 14:19:53 -0700 Subject: [PATCH 3/3] Add assumed screen resolution to comments --- notebook/static/notebook/less/codemirror.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notebook/static/notebook/less/codemirror.less b/notebook/static/notebook/less/codemirror.less index 0de5ebe605..c99bc74848 100644 --- a/notebook/static/notebook/less/codemirror.less +++ b/notebook/static/notebook/less/codemirror.less @@ -56,7 +56,7 @@ border-left: 1.4px solid black; } -// When zoomed out 67% and 33% +// When zoomed out 67% and 33% on a screen of 1440 width x 900 height @media screen and (min-width: 2138px) and (max-width: 4319px) { .CodeMirror-cursor { border-left: 2px solid black;