Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear login cookie on requests without cookie #3380

Merged
merged 1 commit into from
Mar 5, 2018

Commits on Feb 27, 2018

  1. Don't clear login cookie on requests without cookie

    Clearing the secure cookie makes sense when it is invalid or expired,
    but clearing it when it's not sent with a request can unexpectedly log
    the user out.
    
    I ran into this with misconstructed URLs which didn't incorporate
    base_url. That was itself a bug, but the result of suddenly being
    unauthenticated makes it harder to track down.
    
    Closes jupytergh-3365 (hopefully)
    Possibly also relevant to jupytergh-2396
    
    I'm not sure why this seems to affect Firefox more than Chrome.
    takluyver committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    6197248 View commit details
    Browse the repository at this point in the history