From 1c40db244072a618e0fef5be061af31f3abd0f84 Mon Sep 17 00:00:00 2001
From: Dave Foster <dave@axiomdatascience.com>
Date: Thu, 25 Oct 2018 09:36:01 -0400
Subject: [PATCH] Fix default value method for `allow_remote_access` when ip is
 '*'

---
 notebook/notebookapp.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/notebook/notebookapp.py b/notebook/notebookapp.py
index 56ec6deba0..3e63fae3c0 100755
--- a/notebook/notebookapp.py
+++ b/notebook/notebookapp.py
@@ -865,6 +865,12 @@ def _token_changed(self, change):
     @default('allow_remote_access')
     def _default_allow_remote(self):
         """Disallow remote access if we're listening only on loopback addresses"""
+
+        # if blank, self.ip was configured to "*" meaning bind to all interfaces,
+        # see _valdate_ip
+        if self.ip == "":
+            return True
+
         try:
             addr = ipaddress.ip_address(self.ip)
         except ValueError: