From 765c9f7316959e4b3637cf1b123814c02bf84785 Mon Sep 17 00:00:00 2001 From: William Krinsman Date: Wed, 13 Nov 2019 12:02:38 -0800 Subject: [PATCH] Implement Thomas Kluyver's idea -- let the contents and kernel managers get the application option as part of calculating the default --- notebook/notebookapp.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/notebook/notebookapp.py b/notebook/notebookapp.py index 9170428ba1..d05d6e4670 100755 --- a/notebook/notebookapp.py +++ b/notebook/notebookapp.py @@ -1270,14 +1270,6 @@ def _notebook_dir_validate(self, proposal): raise TraitError(trans.gettext("No such notebook dir: '%r'") % value) return value - @observe('notebook_dir') - def _update_notebook_dir(self, change): - """Do a bit of validation of the notebook dir.""" - # setting App.notebook_dir implies setting notebook and kernel dirs as well - new = change['new'] - self.config.FileContentsManager.root_dir = new - self.config.MappingKernelManager.root_dir = new - # TODO: Remove me in notebook 5.0 server_extensions = List(Unicode(), config=True, help=(_("DEPRECATED use the nbserver_extensions dict instead"))