From a73a6c9d9d997d762110fb86004e141180456003 Mon Sep 17 00:00:00 2001 From: yuvipanda <yuvipanda@gmail.com> Date: Thu, 8 Mar 2018 11:10:50 -0800 Subject: [PATCH 1/2] Make daemonsets do a rolling update Without this, the continuous pre-puller pods do not work, since they're stuck in the old image version forever. https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/ has more info --- jupyterhub/templates/image-puller/_helper.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/jupyterhub/templates/image-puller/_helper.yaml b/jupyterhub/templates/image-puller/_helper.yaml index d768cf9408..4ff75c9648 100644 --- a/jupyterhub/templates/image-puller/_helper.yaml +++ b/jupyterhub/templates/image-puller/_helper.yaml @@ -30,6 +30,12 @@ spec: component: {{ .name }} release: {{ .top.Release.Name }} heritage: {{ .top.Release.Service }} + updateStrategy: + type: RollingUpdate + rollingUpdate: + # Arbitrarily large number, since we want all the old daemonsets to die immediately + # and new ones to be born + maxUnavailable: 1000 template: metadata: labels: From ab95bfe1b54e6d707ced56d468b9f68b4ff7933a Mon Sep 17 00:00:00 2001 From: yuvipanda <yuvipanda@gmail.com> Date: Mon, 12 Mar 2018 13:26:29 -0700 Subject: [PATCH 2/2] Use 100% instead of large number for image puller rolling update --- jupyterhub/templates/image-puller/_helper.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/jupyterhub/templates/image-puller/_helper.yaml b/jupyterhub/templates/image-puller/_helper.yaml index 4ff75c9648..26fdaabbda 100644 --- a/jupyterhub/templates/image-puller/_helper.yaml +++ b/jupyterhub/templates/image-puller/_helper.yaml @@ -33,9 +33,7 @@ spec: updateStrategy: type: RollingUpdate rollingUpdate: - # Arbitrarily large number, since we want all the old daemonsets to die immediately - # and new ones to be born - maxUnavailable: 1000 + maxUnavailable: 100% template: metadata: labels: