{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":384277177,"defaultBranch":"master","name":"sonic-buildimage","ownerLogin":"jusherma","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-07-09T00:09:37.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/77471509?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1697526394.0","currentOid":""},"activityList":{"items":[{"before":"5ce2a71dff08c354a1aed35a7ad8fb530a051a1c","after":"80448380e6976a3e326902a37818252abb160dc0","ref":"refs/heads/master","pushedAt":"2024-03-13T07:21:36.000Z","pushType":"push","commitsCount":525,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"Set loglevel for crash kernel to reduce verbosity and improve overall router recovery time (#18285)\n\nWhy I did it\r\nOn certain routers with baud rate 9600, crash kernel is taking a long time , close to ~5mins, to complete kernel dump and reload the box. On contrast to routers with baud rate 115200, crash kernel dump process is observed to be completed under 35s-60s (depending on the platform). Currently, all debug and informational messages are printed on the console which also factors in for the delay seen. Unless the router is monitored on console in real time, these messages are not very useful. Setting the loglevel to warning will help reduce the verbosity of logs on console, in turn allow crash kernel dump process to be completed in a reasonable time which will also help in overall router recovery time.\r\n\r\nHow I did it\r\nSetting loglevel attribute in crashkernel cmdline\r\n\r\nHow to verify it\r\nInstall SONiC image with crashkernel cmdline with loglevel set to warning and initiate an induced a crash (sysrq-trigger)\r\ncrashkernel boot and dump process will be completed in 20s-30s depending on the platform","shortMessageHtmlLink":"Set loglevel for crash kernel to reduce verbosity and improve overall…"}},{"before":null,"after":"7c3a063255c9e0914111ee89b09e2c12c58ec63b","ref":"refs/heads/docker-user-env","pushedAt":"2023-10-17T07:06:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[build] Add DOCKER_USER_ENV option","shortMessageHtmlLink":"[build] Add DOCKER_USER_ENV option"}},{"before":"b444a4674eba94ee2acd67da15a8daf55a59787c","after":"5ce2a71dff08c354a1aed35a7ad8fb530a051a1c","ref":"refs/heads/master","pushedAt":"2023-10-17T06:42:56.000Z","pushType":"push","commitsCount":739,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[submodule] Update submodule sonic-swss to the latest HEAD automatically (#16885)","shortMessageHtmlLink":"[submodule] Update submodule sonic-swss to the latest HEAD automatica…"}},{"before":null,"after":"26600f0ba68e4af639549e4f652be87f56eb2615","ref":"refs/heads/jusherma/cache-online-202211","pushedAt":"2023-04-24T07:18:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[build] SONIC_ONLINE_DEBS no longer overwrites local build outputs","shortMessageHtmlLink":"[build] SONIC_ONLINE_DEBS no longer overwrites local build outputs"}},{"before":null,"after":"e0ef5b9808d430aecd3569ee3fc516b9ffb1580a","ref":"refs/heads/202211","pushedAt":"2023-04-24T07:17:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[write standby] force DB connections to use unix socket to connect (#14524) (#14773)","shortMessageHtmlLink":"[write standby] force DB connections to use unix socket to connect (s…"}},{"before":null,"after":"709a740d92fbdb2b52c59b6f781db5ee4929c376","ref":"refs/heads/jusherma/cache-online-202205","pushedAt":"2023-04-24T07:13:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[build] SONIC_ONLINE_DEBS no longer overwrites local build outputs","shortMessageHtmlLink":"[build] SONIC_ONLINE_DEBS no longer overwrites local build outputs"}},{"before":null,"after":"36b6d5824cf1c388c85d35f05329b2775ecfac9b","ref":"refs/heads/202205","pushedAt":"2023-04-24T07:09:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[ci/build]: Upgrade SONiC package versions (#14812)","shortMessageHtmlLink":"[ci/build]: Upgrade SONiC package versions (sonic-net#14812)"}},{"before":"989cb7e4780af7b53ca2da3183a77f330d31e3f6","after":"0e43b2a735f1d4d46e0d135d0c0931ad4011b3ed","ref":"refs/heads/jusherma/cache-online-202012","pushedAt":"2023-04-24T07:07:09.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"Merge commit 'ae0a47dc6e8bf3925e50f6bb8b0a8b35a4cbc300' into jusherma/cache-online-202012","shortMessageHtmlLink":"Merge commit 'ae0a47dc6e8bf3925e50f6bb8b0a8b35a4cbc300' into jusherma…"}},{"before":"19b212c6a0fea109f875e01007cc934f30f28b64","after":"1f3da955b96162ceed2bcd31b52a63cbad23bed4","ref":"refs/heads/202012","pushedAt":"2023-04-24T07:04:19.151Z","pushType":"push","commitsCount":6,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[S6100] Improve S6100 serial-getty monitor, wait and re-check when getty not running to avoid false alert. (#14402) (#14755)\n\n[S6100] Improve S6100 serial-getty monitor, wait and re-check when getty not running to avoid false alert. \r\n\r\nThis is cherry-pick PR for: https://github.com/sonic-net/sonic-buildimage/pull/14402\r\n\r\n#### Why I did it\r\nOn S6100, the serial-getty service some time can't auto-restart by systemd. So there is a monit unit to check serial-getty service status and restart it.\r\n\r\nHowever, this monit will report false alert, because in most case when serial-getty not running, systemd can restart it successfully.\r\n\r\nTo avoid the false alert, improve the monitor to wait and re-check.\r\n\r\nSteps to reproduce this issue:\r\n1. User login to device via console, and keep the connection.\r\n2. User login to device via SSH, check the serial-getty@ttyS1.service service, it's running.\r\n3. Run 'monit reload' from SSH connection.\r\n4. Check syslog 1 minutes later, there will be false alert: ' 'serial-getty' process is not running'\r\n\r\n##### Work item tracking\r\n- Microsoft ADO :17424426\r\n\r\n#### How I did it\r\nAdd check-getty.sh script to recheck again later when getty service not running.\r\nAnd update monit unit to check serial-getty service status with this script to avoid false alert.\r\n\r\n#### How to verify it\r\nPass all UT.\r\nManually check fixed code work correctly:\r\n\r\n\r\n```\r\nadmin@***:~$ sudo systemctl stop  serial-getty@ttyS1.service\r\nadmin@***:~$ sudo /usr/local/bin/check-getty.sh \r\nadmin@***:~$ echo $?\r\n1\r\nadmin@***:~$ sudo systemctl status serial-getty@ttyS1.service\r\n● serial-getty@ttyS1.service - Serial Getty on ttyS1\r\n     Loaded: loaded (/lib/systemd/system/serial-getty@.service; enabled-runtime; vendor preset: enabled)\r\n     Active: inactive (dead) since Tue 2023-03-28 07:15:21 UTC; 1min 13s ago\r\n\r\nadmin@***:~$ sudo /usr/local/bin/check-getty.sh \r\nadmin@***:~$ echo $?\r\n0\r\nadmin@***:~$ sudo systemctl status serial-getty@ttyS1.service\r\n● serial-getty@ttyS1.service - Serial Getty on ttyS1\r\n     Loaded: loaded (/lib/systemd/system/serial-getty@.service; enabled-runtime; vendor preset: enabled)\r\n```\r\n\r\nsyslog:\r\n```\r\nMar 28 07:10:37.597458 *** INFO systemd[1]: serial-getty@ttyS1.service: Succeeded.\r\nMar 28 07:12:43.010550 *** ERR monit[593]: 'serial-getty' status failed (1) -- no output\r\nMar 28 07:12:43.010744 *** INFO monit[593]: 'serial-getty' trying to restart\r\nMar 28 07:12:43.010846 *** INFO monit[593]: 'serial-getty' stop: '/bin/systemctl stop serial-getty@ttyS1.service'\r\nMar 28 07:12:43.132172 *** INFO monit[593]: 'serial-getty' start: '/bin/systemctl start serial-getty@ttyS1.service'\r\nMar 28 07:13:43.286276 *** INFO monit[593]: 'serial-getty' status succeeded (0) -- no output\r\n```\r\n\r\n#### Tested branch (Please provide the tested image version)\r\n\r\n- [x] 20201231.77\r\n\r\n#### Description for the changelog\r\n[S6100] Improve S6100 serial-getty monitor.","shortMessageHtmlLink":"[S6100] Improve S6100 serial-getty monitor, wait and re-check when ge…"}},{"before":"a14cc768795360f1cd322a0d834b59ce1c71f0aa","after":"b444a4674eba94ee2acd67da15a8daf55a59787c","ref":"refs/heads/master","pushedAt":"2023-04-24T07:02:55.181Z","pushType":"push","commitsCount":17,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"Fix per-command authorization failed issue when a command with wildcard match more than hundred files. (#14787)\n\nFix per-command authorization failed issue when a command with wildcard match more than hundred files.\r\n\r\n\r\n#### Why I did it\r\nWhen user enable TACACS per-command authorization, and run a command with wildcard , if the command match more than hundreds of files, the per-command authorization will failed with following message:\r\n *** authorize failed by TACACS+ with given arguments, not executing\r\n\r\nThe root cause of this issue is because bash will match files with wildcard and replace with wildcard args with matched files. when there are too many files, TACACS plugin will generate a big authorization request, which will be reject by server side. \r\n\r\n##### Work item tracking\r\n- Microsoft ADO **(number only)**: 18074861\r\n\r\n#### How I did it\r\nFix bash patch file, use original user inputs as authorization parameters.\r\n\r\n#### How to verify it\r\nPass all UT.\r\nCreate new UT to validate the TACACS authorization request are using original command arguments.\r\nUT PR: https://github.com/sonic-net/sonic-mgmt/pull/8115\r\n\r\n#### Which release branch to backport (provide reason below if selected)\r\n\r\n- [ ] 201811\r\n- [ ] 201911\r\n- [ ] 202006\r\n- [ ] 202012\r\n- [ ] 202106\r\n- [ ] 202111\r\n- [X] 202205\r\n- [X] 202211\r\n\r\n#### Tested branch (Please provide the tested image version)\r\n\r\n- [x] 202205.258490-412b83d0f\r\n- [x] 202211.71966120-1b971c54b5\r\n\r\n\r\n#### Description for the changelog\r\nFix per-command authorization failed issue when a command with wildcard match more than hundred files.","shortMessageHtmlLink":"Fix per-command authorization failed issue when a command with wildca…"}},{"before":"7da4c4a7a8f28c6e3e3c2f12a9276f25661ec063","after":"f56dd8a2ed331188152e5c7dd3c1cb6ed189cbaf","ref":"refs/heads/jusherma/cache-online-debs","pushedAt":"2023-04-20T05:57:45.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"Merge commit 'a14cc76' into jusherma/cache-online-debs","shortMessageHtmlLink":"Merge commit 'a14cc76' into jusherma/cache-online-debs"}},{"before":"d014b03849c98e7cf60f0246e92e817e4ba15587","after":"a14cc768795360f1cd322a0d834b59ce1c71f0aa","ref":"refs/heads/master","pushedAt":"2023-04-20T05:53:53.140Z","pushType":"push","commitsCount":18,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"Install python-redis package to docker containers (#14632)\n\nInstall python-redis package to docker containers\r\n\r\n#### Why I did it\r\nThis this bug: https://github.com/sonic-net/sonic-buildimage/issues/14531\r\nThe 'flush_unused_database' is part of docker-database, and docker-database does not install python-redis package by itself. it's using redis installed by sonic-py-swsssdk.\r\nSo after remove sonic-py-swsssdk from container, this script break.\r\n\r\nTo this this bug and avoid similer bug happen again, install python-redis to docker containers which removed sonic-py-swsssdk .\r\n\r\n#### How I did it\r\nInstall python-redis to containers.\r\n\r\n#### How to verify it\r\nPass all UT.\r\nCreate new UT to cover this scenario: https://github.com/sonic-net/sonic-mgmt/pull/8032\r\n\r\n#### Description for the changelog\r\nImprove sudo cat command for RO user.","shortMessageHtmlLink":"Install python-redis package to docker containers (sonic-net#14632)"}},{"before":null,"after":"989cb7e4780af7b53ca2da3183a77f330d31e3f6","ref":"refs/heads/jusherma/cache-online-202012","pushedAt":"2023-04-18T01:27:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"SONIC_ONLINE_DEBS no longer overwrites local build outputs","shortMessageHtmlLink":"SONIC_ONLINE_DEBS no longer overwrites local build outputs"}},{"before":"bed4c26b094ec520c9cee53a1bfce94fdbd87872","after":"19b212c6a0fea109f875e01007cc934f30f28b64","ref":"refs/heads/202012","pushedAt":"2023-04-17T07:21:01.121Z","pushType":"push","commitsCount":992,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[ci/build]: Upgrade SONiC package versions (#14679)","shortMessageHtmlLink":"[ci/build]: Upgrade SONiC package versions (sonic-net#14679)"}},{"before":null,"after":"7da4c4a7a8f28c6e3e3c2f12a9276f25661ec063","ref":"refs/heads/jusherma/cache-online-debs","pushedAt":"2023-04-15T00:39:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"SONIC_ONLINE_DEBS no longer overwrites local build outputs\n\nSigned-off-by: Justin Sherman ","shortMessageHtmlLink":"SONIC_ONLINE_DEBS no longer overwrites local build outputs"}},{"before":"deb3e878d7b64196ba4accfcf0ecd032ec2c351b","after":"d014b03849c98e7cf60f0246e92e817e4ba15587","ref":"refs/heads/master","pushedAt":"2023-04-15T00:22:47.857Z","pushType":"push","commitsCount":993,"pusher":{"login":"jusherma","name":"Justin Sherman","path":"/jusherma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77471509?s=80&v=4"},"commit":{"message":"[submodule] Update submodule sonic-utilities to the latest HEAD automatically (#14649)","shortMessageHtmlLink":"[submodule] Update submodule sonic-utilities to the latest HEAD autom…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMy0xM1QwNzoyMTozNi4wMDAwMDBazwAAAAQUKy6F","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMy0xM1QwNzoyMTozNi4wMDAwMDBazwAAAAQUKy6F","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNC0xNVQwMDoyMjo0Ny44NTc2NzVazwAAAAMZLMH3"}},"title":"Activity · jusherma/sonic-buildimage"}