Add python 3.11 support: Remove use of pathlib._Accessor #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pathlib._Accessor` was deprecated and has been removed since Python 3.11, which was making pathy not importable on Python 3.11. Accessor-style classes in pathlib are discouraged, but a simple fix here to make pathy work is to simply remove the deprecated superclass `_Accessor`.
|
@wookayin, thanks so much for reporting that Python 3.11 was not working, and thanks for offering a PR! Unfortunately, Pathy relies on the base pathlib internals for glob matching, so it's not as simple as removing the _Accessor usage. I merged support for 3.11 today if you'd like to see how it had to change: c2a0586 Ideally, we would not rely on the internals of pathlib at all, but that would require adding code to replace the wildcard matching scandir functionality in pathlib.Path. I haven't had time to do that work, but if you'd like to contribute that would be a very welcomed PR. |
|
@justindujardin Thanks! Awesome to see more dedicated python3.11 support (#89). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pathlib._Accessor.Python 3.11 has removed a non-public method
pathlib._Accessor: python/cpython#25701.Accessor-style classes in pathlib are discouraged, but a simple fix here to make pathy work is to simply remove the deprecated superclass
_Accessor.