Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped Registry: MVP after F2F discussion #1

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

caridy
Copy link
Contributor

@caridy caridy commented May 12, 2020

**Updates based on the feedback from the F2F meeting:

  • simplification for MVP
  • removing inheritance between registries
  • removing getDefinitions()
  • removing the ability to new constructors that are not registered in the global registry
  • removing options bag for CustomElementRegistry constructor
  • adding open questions

```

##### Parameters
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in justinfagnani/webcomponents#1 (comment), we can explore the ability to define a batch of components and their names via CustomElementRegistry.prototype.define instead of using a options bag in the constructor. /cc @leobalter

@leobalter
Copy link
Collaborator

friendly ping, @justinfagnani! I'd love to get this unblocked to follow up on the work.

@justinfagnani justinfagnani merged commit b4d1203 into justinfagnani:master Jun 17, 2020
justinfagnani added a commit to justinfagnani/webcomponents that referenced this pull request Sep 23, 2020
annevk pushed a commit to justinfagnani/webcomponents that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants