REFACTOR tasks/variables.yml: use first_found filter for loading of vars files #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoss
force-pushed
the
20230423_rework_variable_loading
branch
from
1b3dc66 to
ca291e1
Compare
|
I believe this should be fine. Amazon Linux did not have a decimal to split the version number on used by other supported distributions at the time. It looks like your changes here should be compatible with this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.ansible.com/ansible/latest/collections/ansible/builtin/first_found_lookup.html#examples
Not sure if both of the first files are needed, IMHO they both do the same thing (unless Amazon Linux does not have the major_version set properly).