From 64381ee4707861d0ee2150dbfbca1fad79855587 Mon Sep 17 00:00:00 2001
From: jy95 <jacques.yakoub@gmail.com>
Date: Thu, 2 May 2024 14:55:49 +0200
Subject: [PATCH] perf: undefinedChecks

---
 src/translators/countCountMax.ts         | 3 ++-
 src/translators/frequencyFrequencyMax.ts | 3 ++-
 src/translators/offsetWhen.ts            | 5 +++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/translators/countCountMax.ts b/src/translators/countCountMax.ts
index f4587f6f..1b40257a 100644
--- a/src/translators/countCountMax.ts
+++ b/src/translators/countCountMax.ts
@@ -3,6 +3,7 @@ import { extractTimingRepeat } from "../internal/extractTimingRepeat";
 import {
   isNotUndefined,
   noUndefinedInArray,
+  allUndefinedInArray,
 } from "../internal/undefinedChecks";
 
 // Types
@@ -24,7 +25,7 @@ export function transformCountCountMaxToText({
   let countMax = repeat.countMax;
 
   // Do nothing if no count, I am not a wizard
-  if (count === undefined && countMax === undefined) {
+  if (allUndefinedInArray(count, countMax)) {
     return undefined;
   }
 
diff --git a/src/translators/frequencyFrequencyMax.ts b/src/translators/frequencyFrequencyMax.ts
index b2f24e02..a4281001 100644
--- a/src/translators/frequencyFrequencyMax.ts
+++ b/src/translators/frequencyFrequencyMax.ts
@@ -3,6 +3,7 @@ import { extractTimingRepeat } from "../internal/extractTimingRepeat";
 import {
   isNotUndefined,
   noUndefinedInArray,
+  allUndefinedInArray,
 } from "../internal/undefinedChecks";
 
 // Types
@@ -24,7 +25,7 @@ export function transformFrequencyFrequencyMaxToText({
   let max = repeat.frequencyMax;
 
   // Do nothing if no frequency / frequencyMax, I am not a wizard
-  if (frequency === undefined && max === undefined) {
+  if (allUndefinedInArray(frequency, max)) {
     return undefined;
   }
 
diff --git a/src/translators/offsetWhen.ts b/src/translators/offsetWhen.ts
index fe232565..5612b047 100644
--- a/src/translators/offsetWhen.ts
+++ b/src/translators/offsetWhen.ts
@@ -2,6 +2,7 @@
 import { fromListToString } from "../utils/fromListToString";
 import { extractTimingRepeat } from "../internal/extractTimingRepeat";
 import { isArrayEmpty } from "../internal/isEmptyArray";
+import { isNotUndefined } from "../internal/undefinedChecks";
 
 // Types
 import type { DisplayOrderParams, I18N } from "../types";
@@ -46,7 +47,7 @@ function extractTime(minutes: number) {
 
 // Function to transform offset into a string
 function transformOffset(i18next: I18N, offset?: number): string | undefined {
-  if (offset === undefined || offset <= 0) {
+  if (!isNotUndefined(offset) || offset <= 0) {
     return undefined;
   }
 
@@ -93,7 +94,7 @@ export function transformOffsetWhenToText({
   let repeat = extractTimingRepeat(dos);
 
   // If empty, return undefined
-  if (repeat === undefined) {
+  if (!isNotUndefined(repeat)) {
     return undefined;
   }