Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transxchange2GoogleTransit doesn't follow best practise in use of types and doesn't use generics #335

Open
GoogleCodeExporter opened this issue Mar 3, 2016 · 0 comments
Open

Transxchange2GoogleTransit doesn't follow best practise in use of types and doesn't use generics #335

GoogleCodeExporter opened this issue Mar 3, 2016 · 0 comments
Labels
auto-migrated

Comments

@GoogleCodeExporter
Copy link 

Transxchange2GoogleTransit uses HashMap and ArrayList in method signatures and 
field variables rather than using Map and List as is best practice.
It doesn't use generics at all which results in casts all over the place and 
reduces type safety (I found one type safety bug in a dumpValues method).

I have a patch which addresses this problem by fixing all the cases.

Original issue reported on code.google.com by scottish...@googlemail.com on 8 Jun 2012 at 10:08

Attachments:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter