From 197e866bf2bb9975d9150af78b286e464761ad84 Mon Sep 17 00:00:00 2001
From: Kosh <kosh20111@gmail.com>
Date: Thu, 9 Mar 2017 21:33:57 +0800
Subject: [PATCH] improving icons padding and size. #108

---
 .../main_layouts/layout/gists_pager_layout.xml       |  8 ++++----
 .../main_layouts/layout/issue_pager_activity.xml     | 12 ++++++------
 .../layouts/main_layouts/layout/search_layout.xml    |  7 ++-----
 .../other_layouts/layout/appbar_search_elevation.xml |  7 +++----
 4 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/app/src/main/res/layouts/main_layouts/layout/gists_pager_layout.xml b/app/src/main/res/layouts/main_layouts/layout/gists_pager_layout.xml
index 2218bb2fb..858185701 100644
--- a/app/src/main/res/layouts/main_layouts/layout/gists_pager_layout.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/gists_pager_layout.xml
@@ -37,8 +37,8 @@
                     android:layout_gravity="center|end"
                     android:contentDescription="@string/star"
                     android:background="?selectableItemBackgroundBorderless"
-                    android:padding="@dimen/spacing_xs_large"
-                    android:scaleType="centerCrop"
+                    android:padding="@dimen/spacing_normal"
+                    
                     android:src="@drawable/ic_star"/>
 
                 <com.fastaccess.ui.widgets.ForegroundImageView
@@ -48,8 +48,8 @@
                     android:layout_gravity="center|end"
                     android:contentDescription="@string/fork"
                     android:background="?selectableItemBackgroundBorderless"
-                    android:padding="@dimen/spacing_xs_large"
-                    android:scaleType="centerCrop"
+                    android:padding="@dimen/spacing_normal"
+                    
                     android:src="@drawable/ic_fork"/>
             </android.support.v7.widget.Toolbar>
 
diff --git a/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml b/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml
index 2836dda55..097c0a2ef 100644
--- a/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml
@@ -33,22 +33,22 @@
                 <com.fastaccess.ui.widgets.ForegroundImageView
                     android:id="@+id/startGist"
                     android:layout_width="wrap_content"
-                    android:layout_height="match_parent"
+                    android:layout_height="wrap_content"
                     android:layout_gravity="center|end"
-                    android:contentDescription="@string/star"
                     android:background="?selectableItemBackgroundBorderless"
-                    android:padding="@dimen/spacing_xs_large"
+                    android:contentDescription="@string/star"
+                    android:padding="@dimen/spacing_normal"
                     android:scaleType="centerCrop"
                     android:src="@drawable/ic_star"/>
 
                 <com.fastaccess.ui.widgets.ForegroundImageView
                     android:id="@+id/forkGist"
                     android:layout_width="wrap_content"
-                    android:layout_height="match_parent"
+                    android:layout_height="wrap_content"
                     android:layout_gravity="center|end"
-                    android:contentDescription="@string/fork"
                     android:background="?selectableItemBackgroundBorderless"
-                    android:padding="@dimen/spacing_xs_large"
+                    android:contentDescription="@string/fork"
+                    android:padding="@dimen/spacing_normal"
                     android:scaleType="centerCrop"
                     android:src="@drawable/ic_fork"/>
             </android.support.v7.widget.Toolbar>
diff --git a/app/src/main/res/layouts/main_layouts/layout/search_layout.xml b/app/src/main/res/layouts/main_layouts/layout/search_layout.xml
index 52d6020a7..881e87e7b 100644
--- a/app/src/main/res/layouts/main_layouts/layout/search_layout.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/search_layout.xml
@@ -53,14 +53,11 @@
                     <com.fastaccess.ui.widgets.ForegroundImageView
                         android:id="@+id/clear"
                         android:layout_width="wrap_content"
-                        android:layout_height="match_parent"
+                        android:layout_height="wrap_content"
                         android:layout_gravity="center"
                         android:contentDescription="@string/clear"
                         android:background="?selectableItemBackgroundBorderless"
-                        android:paddingBottom="@dimen/spacing_xs_large"
-                        android:paddingEnd="@dimen/spacing_xs_large"
-                        android:paddingStart="@dimen/spacing_xs_large"
-                        android:paddingTop="@dimen/spacing_xs_large"
+                        android:padding="@dimen/spacing_normal"
                         android:scaleType="centerCrop"
                         android:src="@drawable/ic_clear"
                         android:visibility="invisible"/>
diff --git a/app/src/main/res/layouts/other_layouts/layout/appbar_search_elevation.xml b/app/src/main/res/layouts/other_layouts/layout/appbar_search_elevation.xml
index 107d84185..c83f3a462 100644
--- a/app/src/main/res/layouts/other_layouts/layout/appbar_search_elevation.xml
+++ b/app/src/main/res/layouts/other_layouts/layout/appbar_search_elevation.xml
@@ -29,11 +29,11 @@
         <com.fastaccess.ui.widgets.ForegroundImageView
             android:id="@+id/searchIcon"
             android:layout_width="wrap_content"
-            android:layout_height="match_parent"
+            android:layout_height="wrap_content"
             android:layout_gravity="center"
             android:background="?selectableItemBackgroundBorderless"
+            android:padding="@dimen/spacing_normal"
             android:scaleType="centerCrop"
-            android:padding="@dimen/spacing_xs_large"
             android:src="@drawable/ic_search"/>
 
         <com.fastaccess.ui.widgets.FontEditText
@@ -58,10 +58,9 @@
             android:layout_height="match_parent"
             android:layout_gravity="center"
             android:background="?selectableItemBackgroundBorderless"
-            android:scaleType="centerCrop"
             android:src="@drawable/ic_clear"
             tools:visibility="visible"
-            android:padding="@dimen/spacing_xs_large"
+            android:padding="@dimen/spacing_normal"
             android:visibility="invisible"/>
 
     </LinearLayout>