Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix udp service access through k3d-proxy (fixes #489) (#488, @k0da) #488

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[FIX] Fix udp service access through k3d-proxy (fixes #489) (#488, @k0da) #488

merged 1 commit into from
Feb 9, 2021

Conversation

k0da
Copy link
Contributor

@k0da k0da commented Feb 8, 2021

This commit separates PORTS and UDP_PORTS and configures
nginx appropriately.

Signed-off-by: Dinar Valeev dinar.valeev@absa.africa

@k0da k0da changed the title Fix udp service access through k3d-proxy [FIX] Fix udp service access through k3d-proxy Feb 9, 2021
@k0da
Copy link
Contributor Author

k0da commented Feb 9, 2021

fixes #489

@k0da k0da changed the title [FIX] Fix udp service access through k3d-proxy [FIX] Fix udp service access through k3d-proxy (#489) Feb 9, 2021
iwilltry42
iwilltry42 requested changes Feb 9, 2021
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot :)
Just it seems that the confd dependency leaked in there, which doesn't have to be there 👍
UPDATE: also please rebase on (or merge) the latest changes in main 👍

go.mod Outdated Show resolved Hide resolved
@k0da
Fix udp service access through k3d-proxy
8a49fe8 
This commit separates PORTS and UDP_PORTS and configures
nginx appropriately.

Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
@iwilltry42 iwilltry42 changed the title [FIX] Fix udp service access through k3d-proxy (#489) [FIX] Fix udp service access through k3d-proxy (fixes #489) (#488, @k0da) Feb 9, 2021
@iwilltry42 iwilltry42 merged commit 78c22f7 into k3d-io:main Feb 9, 2021
@iwilltry42
Copy link
Member

Thank you for your contribution! :)

rancherio-gh-m pushed a commit that referenced this pull request Feb 9, 2021
@k0da
commit 78c22f7
283068e 
Author: Dinar Valeev <k0da@opensuse.org>
Date:   Tue Feb 9 16:48:44 2021 +0100

    [FIX] Fix udp service access through k3d-proxy (fixes #489) (#488, @k0da)
@iwilltry42 iwilltry42 mentioned this pull request Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0da @iwilltry42