Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add watsonx ai provider #482

Merged
merged 5 commits into from
Sep 29, 2024
Merged

feat: add watsonx ai provider #482

merged 5 commits into from
Sep 29, 2024

Conversation

liyanwei93
Copy link
Contributor

@liyanwei93 liyanwei93 commented Jul 25, 2024

Signed-off-by: yanweili yanweili@ibm.com

Closes #

📑 Description

Add IBM watsonx ai as AI provider for k8sGPT.
Document: k8sgpt-ai/docs#107

PR in k8sgpt: k8sgpt-ai/k8sgpt#1163

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: yanweili <yanweili@ibm.com>
@liyanwei93 liyanwei93 requested review from a team as code owners July 25, 2024 04:44
@gyliu513
Copy link

This has a dependency with k8sgpt-ai/k8sgpt#1234

@gyliu513
Copy link

@liyanwei93 can you help update this PR a bit based on k8sgpt-ai/k8sgpt#1234? I have renamed watsonxai to ibmwatsonxai, thanks!

Signed-off-by: yanweili <yanweili@ibm.com>
@@ -140,7 +140,7 @@ const (
Cohere = "cohere"
Google = "google"
GoogleVertexAI = "googlevertexai"
WatsonXAI = "watsonxai"
IBMWatsonXAI = "ibmwatsonxai"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we use IBMWatsonxAI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Signed-off-by: yanweili <yanweili@ibm.com>
@gyliu513
Copy link

hey @AlexsJones can you help review or delegate to others for review? Thanks

liyanwei93 and others added 2 commits September 25, 2024 20:22
Signed-off-by: yanweili <yanweili@ibm.com>
@liyanwei93
Copy link
Contributor Author

Hi @AlexsJones, all dependent PRs have been merged. Could you please help to review this one. Thanks in advanced.

@AlexsJones AlexsJones merged commit bf65ff4 into k8sgpt-ai:main Sep 29, 2024
7 checks passed
aghilish pushed a commit to aghilish/k8sgpt-operator that referenced this pull request Sep 30, 2024
* feat: add watsonx ai provider
Signed-off-by: yanweili <yanweili@ibm.com>

* rename to ibmwatsonxai

Signed-off-by: yanweili <yanweili@ibm.com>

* rename to IBMWatsonxAI

Signed-off-by: yanweili <yanweili@ibm.com>

* change the secret key name

Signed-off-by: yanweili <yanweili@ibm.com>

---------

Signed-off-by: yanweili <yanweili@ibm.com>
Co-authored-by: yanweili <yanweili@ibm.com>
Signed-off-by: Shahrooz Aghili <shahrooz33ce@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants