feat: init ingress analyzer #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
matthisholleville
force-pushed
the
feature/ingress-analyzer
branch
from
d3b2d93 to
5e1275f
Compare
thschue
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136
📑 Description
As discussed on this issue, it would be interesting to add an ingress analyzer. The MR proposes a very naive version of an ingress analyzer that checks that the service used by the ingress is present.
✅ Checks
ℹ Additional Information
I deliberately only took care of the
networking.k8s.io/v1version of ingress sinceextensions/v1beta1has been deprecated for some time. Therefore, the code is not compatible with ingress that usesextensions/v1beta1.