Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filter command add "list" subcommand #159

Merged
merged 3 commits into from
Mar 30, 2023
Merged

feat: add filter command add "list" subcommand #159

merged 3 commits into from
Mar 30, 2023

Conversation

matthisholleville
Copy link
Contributor

Closes #

📑 Description

As mentioned in this issue #158, this PR adds a command to list the available filters.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@matthisholleville
feat: add filter command add "list" subcommand to display available f…
321b15b 
…ilters

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested a review from a team as a code owner March 30, 2023 16:33
AlexsJones
AlexsJones requested changes Mar 30, 2023
View reviewed changes
cmd/filters/filters.go Outdated Show resolved Hide resolved
@matthisholleville
feat: create specific file to filterList
9e9ca39 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville
feat: rename ListAnalyzers to ListFilters
a08e773 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
thschue
thschue approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 6e17c9e into k8sgpt-ai:main Mar 30, 2023
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Merged
fyuan1316 pushed a commit to fyuan1316/k8sgpt that referenced this pull request Jun 26, 2023
@AlexsJones
feat: refactor the ai spec (k8sgpt-ai#159)
6e1c394 
* feat: refactor the ai spec

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

* chore: updated helm chart CR

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

* chore: fixed failing test

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>

---------

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Co-authored-by: Aris Boutselis <aris.boutselis@senseon.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones requested changes

@thschue thschue thschue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthisholleville @AlexsJones @thschue