Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deployment/cronjob analyzers namespace filtering #290

Merged
merged 2 commits into from
Apr 17, 2023
Merged

fix: deployment/cronjob analyzers namespace filtering #290

merged 2 commits into from
Apr 17, 2023

Conversation

matthisholleville
Copy link
Contributor

Closes #

📑 Description

These changes address an issue with the Cronjob and Deployment analyzers. The namespace flag was not being taken into account for these two analyzers, resulting in returning all deployments/cronjobs from all namespaces of a cluster even if the --namespace flag was specified.

I took the opportunity to add tests to the existing analyzers to prevent regressions in the future.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@matthisholleville
fix: deployment/cronjob namespace filtering
9296e7d 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested review from a team as code owners April 17, 2023 09:17
@matthisholleville matthisholleville changed the title fix: deployment/cronjob namespace filtering fix: deployment/cronjob analyzers namespace filtering Apr 17, 2023
thschue
thschue approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 3d684a2 into k8sgpt-ai:main Apr 17, 2023
@github-actions github-actions bot mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthisholleville @thschue