Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure parent directories are created in EnsureDirExists function #293

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

matthisholleville
Copy link
Contributor

Closes #

📑 Description

The previous implementation of the EnsureDirExists function only created a
single directory, which resulted in an error if the parent directories did
not exist. This fix updates the function to create parent directories
recursively using os.MkdirAll.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested review from a team as code owners April 17, 2023 13:07
@AlexsJones AlexsJones enabled auto-merge (squash) April 17, 2023 13:38
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@AlexsJones AlexsJones merged commit af8b350 into k8sgpt-ai:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants