feat: add Azure remote cache #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexsJones
reviewed
Oct 1, 2023
arbreezy
force-pushed
the
feat/add-remote-cache-azure
branch
2 times, most recently
from
24459b1
to
31f6a32
Compare
arbreezy
force-pushed
the
feat/add-remote-cache-azure
branch
from
31f6a32
to
8579fa2
Compare
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
….0 (k8sgpt-ai#687) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
… v1.3.0-20231002095256-194bc640518b.1 (k8sgpt-ai#692) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…hub.com/k8sgpt-ai/k8sgpt/security/code-scanning/1 (k8sgpt-ai#695) Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
…ffers/go to v1.31.0-20231002095256-194bc640518b.1 (k8sgpt-ai#693) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…k8sgpt-ai#689) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
…t-ai#685) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…3.0 (k8sgpt-ai#683) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
…t-ai#696) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…t-ai#697) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
…t-ai#699) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
…t-ai#701) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
arbreezy
force-pushed
the
feat/add-remote-cache-azure
branch
from
8579fa2
to
a286e66
Compare
added 2 commits
October 11, 2023 19:45
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
AlexsJones
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
This has to be cautiously merged as it will break the caching functionality in the operator I believe @arbreezy
|
@AlexsJones that's right, I am picking up the operator's work shortly |
|
Should this get merged in after you do the operator work or now @arbreezy ? |
|
@AlexsJones tbh, we already merged unintentionally the proto schema changes in the operator, which was the main argument of not merging this PR until the grpc client is compatible so in my eyes this could be merged and potentially released without breaking more the existing state of things |
AlexsJones
approved these changes
Oct 20, 2023
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
PR adds a new remote cache, integrating with Azure Blob storage offering.
It also includes the new protobuf schema.
Finally, it reworks the cache code path to make it easier to introduce more remote cache types in the future
✅ Checks
ℹ Additional Information