Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add fakeai provider #218

Merged
merged 7 commits into from
Apr 6, 2023
Merged

chore: add fakeai provider #218

merged 7 commits into from
Apr 6, 2023

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Apr 5, 2023 •
edited
Loading

Closes #

📑 Description

  • Create an fakeai provider for local development, testing and troubleshooting
  • This provider simply echoes the input given as problem

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

The output looks like this:
image

@thschue
chore: add fakeai provider
2ba3bf7 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
chore: add fakeai provider
f8fb4df 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue thschue requested a review from a team as a code owner April 5, 2023 12:53
matthisholleville
matthisholleville reviewed Apr 5, 2023
View reviewed changes
pkg/ai/ai.go Outdated Show resolved Hide resolved
@matthisholleville
Copy link
Contributor

matthisholleville commented Apr 5, 2023 •
edited
Loading

Shouldn't we rename ai.go to openai.go now that we have two backends? Anyway, this fake client can easily help us develop more comprehensive tests on the core features of the tool. Good job!

AlexsJones
AlexsJones reviewed Apr 5, 2023
View reviewed changes
pkg/ai/fakeai.go Outdated Show resolved Hide resolved
@thschue
fix: name of openai provider
de0a3b8 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
fix: renamed fakeai backend to noopai
f36be8d 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
Merge branch 'main' of github.com:k8sgpt-ai/k8sgpt into chore/fake-ai…
a7ce455 
…-provider
@thschue
fix: renamed fakeai backend to noopai
47e6f6e 
Signed-off-by: Thomas Schuetz <thomas.schuetz@t-sc.eu>
@thschue
Copy link
Contributor Author

thschue commented Apr 6, 2023

Shouldn't we rename ai.go to openai.go now that we have two backends? Anyway, this fake client can easily help us develop more comprehensive tests on the core features of the tool. Good job!

Renamed it to openai.go

@matthisholleville
Copy link
Contributor

Regarding the latest minor detail, you indicated that the modification made required an update in the documentation, which has already been modified. However, I have noticed that the readme file is missing in this commit. Could you confirm if this is an expected outcome?

@thschue thschue mentioned this pull request Apr 6, 2023
Closed
4 tasks
@thschue
Copy link
Contributor Author

thschue commented Apr 6, 2023

Regarding the latest minor detail, you indicated that the modification made required an update in the documentation, which has already been modified. However, I have noticed that the readme file is missing in this commit. Could you confirm if this is an expected outcome?

Created an Issue here: k8sgpt-ai/docs#13

@thschue thschue merged commit e449cb6 into main Apr 6, 2023
@thschue thschue deleted the chore/fake-ai-provider branch April 6, 2023 19:10
@github-actions github-actions bot mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

@matthisholleville matthisholleville Awaiting requested review from matthisholleville

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thschue @matthisholleville @AlexsJones