Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add serviceMonitor in sample yaml #304

Merged
merged 3 commits into from
Apr 21, 2023
Merged

chore: add serviceMonitor in sample yaml #304

merged 3 commits into from
Apr 21, 2023

Conversation

panpan0000
Copy link
Contributor

Closes #

📑 Description

To support #273

  • add serviceMonitor CR ( but if there's no prometheus-operator in cluster, CRD will be absent, but no bad thing will happen)
  • reduce the CPU request
  • add label to service , so serviceMonitor can find the service.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Test result snapshot:

image

image

@panpan0000 panpan0000 requested review from a team as code owners April 20, 2023 06:53
@panpan0000 panpan0000 changed the title add serviceMonitor in sample yaml chore: add serviceMonitor in sample yaml Apr 20, 2023
@panpan0000
chore: add serviceMonitor in sample yaml
de9bde1 
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@AlexsJones
Copy link
Member

Great stuff, this will fail though if someone doesn't have the CRD installed.
Though given this isn't documented I suppose we know just now this feature is for "advanced' users

arbreezy
arbreezy approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I think the next step is to helmify the k8s manifests and control the creation of servicemonitor in values.yaml. I will create a new issue.

thschue
thschue requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! lgtm

@AlexsJones AlexsJones merged commit 0a4ed0d into k8sgpt-ai:main Apr 21, 2023
@github-actions github-actions bot mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

@arbreezy arbreezy arbreezy approved these changes

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panpan0000 @AlexsJones @arbreezy @thschue