Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support CNI runtimeConfig for Mac configuration #104

Closed
zshi-redhat opened this issue Oct 8, 2019 · 1 comment · Fixed by #105
Closed

support CNI runtimeConfig for Mac configuration #104

zshi-redhat opened this issue Oct 8, 2019 · 1 comment · Fixed by #105
Labels
enhancement

Comments

@zshi-redhat
Copy link
Collaborator

zshi-redhat commented Oct 8, 2019 •
edited
Loading

What would you like to be added?

Multus is changing to use CNI runtimeConfig for mac, see k8snetworkplumbingwg/multus-cni#387
This request is to have SR-IOV CNI support CNI runtimeConfig for mac.

What is the use case for this feature / enhancement?

Assign static mac address to VF device per pod.
@zshi-redhat zshi-redhat changed the title support CNI runtimeConfig for Mac and IP configuration support CNI runtimeConfig for Mac configuration Oct 11, 2019
@zshi-redhat zshi-redhat mentioned this issue Oct 11, 2019
Merged
@zshi-redhat
Copy link
Collaborator Author

removing IP from the issue description.
static ipam plugin will be responsible for static ip configuration, there is no need to change sr-iov cni in order to support static ip.

zshi-redhat added a commit to zshi-redhat/sriov-cni that referenced this issue Oct 15, 2019
@zshi-redhat
support CNI RuntimeConfig for Mac
70a10af 
CNI RuntimeConfig takes preference if configured,
envArgs can still be used for Mac configuration if
meta plugin(Multus) passes Mac as envArgs.

Fixes k8snetworkplumbingwg#104
ahalimx86 pushed a commit that referenced this issue Oct 15, 2019
@zshi-redhat @ahalimx86
support CNI RuntimeConfig for Mac (#105)
c9e13c3 
CNI RuntimeConfig takes preference if configured,
envArgs can still be used for Mac configuration if
meta plugin(Multus) passes Mac as envArgs.

Fixes #104
krsacme pushed a commit to krsacme/sriov-cni that referenced this issue Aug 25, 2020
@zshi-redhat
support CNI RuntimeConfig for Mac (k8snetworkplumbingwg#105)
20441b5 
CNI RuntimeConfig takes preference if configured,
envArgs can still be used for Mac configuration if
meta plugin(Multus) passes Mac as envArgs.

Fixes k8snetworkplumbingwg#104
thom311 pushed a commit to thom311/k8snetworkplumbingwg-sriov-cni that referenced this issue Jun 3, 2024
@openshift-merge-bot
Merge pull request k8snetworkplumbingwg#104 from SchSeba/merge-bot-ma…
316ab0e 
…ster

OCPBUGS-33799: Merge https://github.com/k8snetworkplumbingwg/sriov-cni:master into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support CNI RuntimeConfig for Mac zshi-redhat/sriov-cni
1 participant
@zshi-redhat