Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint target #288

Closed
rollandf opened this issue Apr 26, 2022 · 3 comments
Closed

Add golangci-lint target #288

rollandf opened this issue Apr 26, 2022 · 3 comments

Comments

@rollandf
Copy link
Contributor

For better lint, add golangci-lint tool to project
@rollandf rollandf mentioned this issue Apr 26, 2022
Merged
@adrianchiris
Copy link
Collaborator

+1 on this

we can reference from sriov-network-device-plugin

GA:
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/58eb3660dcaeec068c8c8878825c6d724020966a/.github/workflows/build-test-lint.yml#L45

adding a .golangci.yaml for linter config
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/58eb3660dcaeec068c8c8878825c6d724020966a/.github/workflows/build-test-lint.yml#L45

and makefile target
https://github.com/Mellanox/rdma-cni/blob/b013003eae5344065fa47699aecde4a733234faa/Makefile#L81

This was referenced Apr 27, 2022
Merged
Merged
Merged
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
c5896f9 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
65e5d23 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
2a17c52 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@rollandf rollandf mentioned this issue Apr 28, 2022
Merged
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
74d466a 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
f3bd9e1 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
6ec73c2 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
f0c205a 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 28, 2022
@rollandf
Add golangci-lint
4d89c2d 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 1, 2022
@rollandf
Add golangci-lint
a5f31f9 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 2, 2022
@rollandf
Add golangci-lint
9bf59d6 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 8, 2022
@rollandf
Add golangci-lint
548b2cc 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 8, 2022
@rollandf
Add golangci-lint
8287d15 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 11, 2022
@rollandf
Add golangci-lint
ecaf1c9 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 12, 2022
@rollandf
Add golangci-lint
f64bfe5 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 17, 2022
@rollandf
Add golangci-lint
87cfce8 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 18, 2022
@rollandf
Add golangci-lint
11990cb 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue May 30, 2022
@rollandf
Add golangci-lint
a36b2a7 
- Add golangci.yaml config file
- Add Makefile lint target to golangci-lint
- Add GitHub action

Related to issue k8snetworkplumbingwg#288

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@SchSeba
Copy link
Collaborator

SchSeba commented Aug 11, 2022

@rollandf can we close this one or we are still missing some features?

@rollandf
Copy link
Contributor Author

We can close it. There are still linters that are commented out, but we can handle them without this issue.

@SchSeba SchSeba closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SchSeba @rollandf @adrianchiris