Add a sanity check test suite #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pliurh
reviewed
May 19, 2021
test/validation/tests/validation.go
Outdated
|
|
||
| isClusterReady, err := cluster.IsClusterStable(clients) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| Expect(isClusterReady).To(BeFalse(), "Cluster is not stable") |
There was a problem hiding this comment.
We shall expect isClusterReady to be true here, right?
There was a problem hiding this comment.
Oh dang, good catch! It's a leftover from me validating the script. Will change
hack/deploy-wait.sh
Outdated
| echo "Timed out waiting for features to be ready" | ||
| oc get nodes | ||
| exit 1 | ||
| fi |
This adds a "validation" test suite that perform very basic tests. It checks that all the crds are deployed, and that the pods are running correctly. This serves two purpouses: - having a toggle to understand when a deployment finished (implemented by the make deploy-wait rule) - having a set of tests able to prevent DOA releases, verifying that the operator deploys correctly (even without needing a baremetal cluster) Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "validation" test suite that perform very basic tests. It checks that all the crds are deployed, and that the pods are running correctly.
This serves two purposes: