Make mstflint configurable for config daemon #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstflint in CentOS repository is too old and doesn't support latest Nvidia Nics like BlueField 2. This patch makes mstflint package location configurable so we can build image with required version and location of it.
adrianchiris
approved these changes
Aug 1, 2021
There was a problem hiding this comment.
/lgtm
to get bluefield-2 support in mstflint by default, base image should change to be centos8(ish)
since support was added inbox from mstflint version 4.14
However i can see benefits of having this configurable even if the base image is bumped (e.g if we want to pin this to a certain version or for testing)
whats available today in 8-stream:
http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/Packages/mstflint-4.15.0-1.el8.x86_64.rpm
moshe010
approved these changes
Aug 1, 2021
zshi-redhat
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mstflint in CentOS repository is too old and doesn't support latest
Nvidia Nics like BlueField 2.
This patch makes mstflint package location configurable so we can
build image with required version and location of it.