Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "yum update" command from config-daemon Dockerfile #270

Merged

Conversation

ykulazhenkov
Copy link
Collaborator

Remove "yum update" command from Dockerfile.sriov-network-config-daemon.

For config-daemon, centos:stream8 is used as a base image.
This image is actively maintained and should include available security updates with minimal delay.

The reason for this change is that latest(current) version of centos:stream8 image has following problem:

sudo docker run -ti --rm quay.io/centos/centos:stream8
[root@08c3ef94d916 /]# yum update
CentOS Stream 8 - AppStream                                                                                                                                                    7.8 MB/s |  21 MB     00:02    
CentOS Stream 8 - BaseOS                                                                                                                                                       8.0 MB/s |  20 MB     00:02    
CentOS Stream 8 - Extras                                                                                                                                                        26 kB/s |  18 kB     00:00    
Error: 
 Problem: package centos-stream-repos-8-4.el8.noarch requires centos-gpg-keys = 1:8-4.el8, but none of the providers can be installed
  - cannot install both centos-gpg-keys-1:8-5.el8.noarch and centos-gpg-keys-1:8-4.el8.noarch
  - cannot install the best update candidate for package centos-stream-repos-8-4.el8.noarch
  - cannot install the best update candidate for package centos-gpg-keys-1:8-4.el8.noarch
(try to add '--allowerasing' to command line to replace conflicting packages or '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

So, this change is a workaround to fix the problem above, but this change can be safely persist while centos:stream8 image
is maintained and keep receiving updates.

Remove "yum update" command from
Dockerfile.sriov-network-config-daemon.

For config-daemon, centos:stream8 is used as a base image.
This image is actively maintained and should receive
security updates with minimal delay.

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@pliurh pliurh merged commit 1e0fc79 into k8snetworkplumbingwg:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants