Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ineffassign issues #291

Merged
merged 1 commit into from
May 18, 2022
Merged

Fix ineffassign issues #291

merged 1 commit into from
May 18, 2022

Conversation

rollandf
Copy link
Contributor

Fix issues found by:
golangci-lint run --disable-all -E ineffassign

Signed-off-by: Fred Rolland frolland@nvidia.com

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@rollandf
Copy link
Contributor Author

See issue #288

@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request fixes 3 alerts when merging 2d63f90 into 0030dda - view on LGTM.com

fixed alerts:

  • 3 for Useless assignment to local variable

@SchSeba
Copy link
Collaborator

SchSeba commented May 17, 2022

@rollandf can you please rebase?

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@rollandf
Copy link
Contributor Author

@SchSeba rebased

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request fixes 3 alerts when merging ee6e56b into 9a71b6e - view on LGTM.com

fixed alerts:

  • 3 for Useless assignment to local variable

adrianchiris
adrianchiris reviewed May 18, 2022
View reviewed changes
test/conformance/tests/sriov_operator.go Outdated
@@ -1970,6 +1971,37 @@ func createSriovPolicy(sriovDevice string, testNode string, numVfs int, resource
}, 10*time.Minute, time.Second).Should(Equal(int64(numVfs)))
}

func createUnschedulableTestPod(node string, networks []string, resourceName string) {
Copy link
Collaborator

@adrianchiris adrianchiris May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rollandf you added this ? or a rebase creep in ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems a rebase issue. Fixing.

@rollandf
Fix ineffassign issues
cebbdb3 
Fix issues found by:
`golangci-lint run --disable-all -E ineffassign`

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@lgtm-com
Copy link

lgtm-com bot commented May 18, 2022

This pull request fixes 3 alerts when merging cebbdb3 into 9a71b6e - view on LGTM.com

fixed alerts:

  • 3 for Useless assignment to local variable

@adrianchiris
Copy link
Collaborator

thanks @rollandf ! :)

@adrianchiris adrianchiris merged commit b1122b0 into k8snetworkplumbingwg:master May 18, 2022
@rollandf rollandf deleted the ineffassign branch June 6, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rollandf @SchSeba @adrianchiris