-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Intel X557 Family #332
add support for Intel X557 Family #332
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Just a question on feature supportability.
@@ -5,6 +5,7 @@ The following SR-IOV capable hardware is supported with sriov-network-operator: | |||
| Model | Vendor ID | Device ID | | |||
| ------------------------ | --------- | --------- | | |||
| Intel XXV710 Family | 8086 | 158b | | |||
| Intel X557 Family | 8086 | 1589 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a second table below in the "Supported features per hardware" section. Would you be able to share what is working for you? I think "SR-IOV Kernel" and "SR-IOV DPDK" work fine but input from you would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea! Absolutely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Thanks for your PR,
To skip the vendors CIs use one of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
@Eoghan1232 @eoghanlawless can you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Greetings :) and thx for adding support for new hardware ! for adding a new hardware we have defined a process: missing just the issue creation + updating with what was tested in the issue. Also could you reformat commit message, first line after header is too long Thanks ! |
Here is the issue @adrianchiris And commit message reformatted. |
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 2722484234
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Linter just hit timeout. as there are no code changes its not really relevant
The Intel Ethernet Connection X557 family is utilized in IBM Cloud bare metals. This adds support for being able to utilize SR-IOV in IBM Cloud when the bare metals have those ethernet cards.