Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NAD client #431

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Update NAD client #431

merged 1 commit into from
Apr 24, 2023

Conversation

rollandf
Copy link
Contributor

@rollandf
Update NAD client
39967d8 
Fix CVE-2021-20206

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4778688438

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 25.659%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 67.92%
controllers/sriovnetwork_controller.go 2 67.62%
api/v1/helper.go 3 41.92%
Totals Coverage Status
Change from base Build 4607991591: 0.01%
Covered Lines: 1938
Relevant Lines: 7553
💛 - Coveralls

SchSeba
SchSeba approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing thanks!

/lgtm

@adrianchiris
Copy link
Collaborator

/test-all

adrianchiris
adrianchiris approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets have mlnx CI passing b4 merge

@adrianchiris adrianchiris merged commit 3588c88 into k8snetworkplumbingwg:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rollandf @coveralls @adrianchiris @e0ne @SchSeba