Deduplicate prune #148
Closed
Deduplicate prune #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweibel
force-pushed
the
feat-deduplicate-prune
branch
from
07facc3
to
07a6376
Compare
ccremer
suggested changes
Nov 20, 2020
Comment on lines
+3
to
+4
| // Type defines what job type this is. | ||
| type Type string |
There was a problem hiding this comment.
I think this is highly confusing with the built-in Go's "type"
Suggested change
| // Type defines what job type this is. | |
| type Type string | |
| // JobType defines what kind a certain job is. | |
| type JobType string |
|
With the additional information from the customer in #118 unfortunately just skipping if another one of these jobs is already running isn't the desired result here. The main problem they want to solve is, that they have multiple backups pointing to the same repository which all have a prune job defined that runs weekly at random days. But they don't want the prunes to run for each definition, instead the operator should see that there are multiple prune definitions that all run during the same period (like weekly) and then only run it once. |
|
ah right that's the reason ;) |
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #147 (that's why those commits are in there as well. Will need to rebase after merging that PR).
This change ensures that the restic repository is always available and set on jobs which is required for the queue to be able to detect which jobs are running against which repository. It adds a test related to this case to document and ensure what the execution queue does works.
Additionally it refactors to have a type for the possible job types.
I'm not entirely sure if this solves #118 already. There's code (worker.go) which ensures a job isn't run if there's another exclusive job running or an exclusive job isn't running if there is any other job running.
However that same code also is probably misbehaving (I'd still have to check, or rather: one should write a test for this):
shouldRun-> falseAt this point job B is never run, as it's gone from the queue and doesn't get re-added.
Correct me if I misinterpret the code please :)