Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery; conditionally compile plugin system #55

Merged
merged 3 commits into from
Jul 20, 2015
Merged

Remove jQuery; conditionally compile plugin system #55

merged 3 commits into from
Jul 20, 2015

Conversation

tomkwok
Copy link
Contributor

@tomkwok tomkwok commented Jul 17, 2015

  • Replace jQuery with Zepto.js http://zeptojs.com/, which is much more lightweight. Zepto doesn't support IE 9 or below, but anyway we don't have to, as I, you and most, if not all, potential users of Journey don't use IE...
32K zepto.min.js
12K zepto.min.js.gz

84K jquery-2.1.4.min.js
32K jquery-2.1.4.min.js.gz

Note: I've added this line: window.jQuery=Zepto; so that we don't have to modify existing minified files from javascript libraries, namely autosize.js, bootstrap and bootstrap-fileinput.


@kabukky What new features are WIP?


@tomkwok tomkwok changed the title Remove jQuery Remove jQuery; conditionally complie plugin system Jul 18, 2015
@tomkwok tomkwok changed the title Remove jQuery; conditionally complie plugin system Remove jQuery; conditionally compile plugin system Jul 18, 2015
@kabukky
Copy link
Owner

kabukky commented Jul 20, 2015

Great work, thanks! 👍
I haven't been following the developments around jQuery auto injection in Ghost, so this is a (welcome) surprise. I hated that behavior.
I guess we have to put that into the next release announcement as well, so that users won't be confused if their themes break.

I'm about to fork https://github.com/gorilla/feeds to customize it to our wishes.
Once that's done I guess it's time for another release.

kabukky added a commit that referenced this pull request Jul 20, 2015
Remove jQuery; conditionally compile plugin system
@kabukky kabukky merged commit 409bec7 into kabukky:development Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants