remove emit-event shim #1168
Merged
remove emit-event shim #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imalsogreg
reviewed
Mar 22, 2023
imalsogreg
reviewed
Mar 22, 2023
imalsogreg
reviewed
Mar 22, 2023
imalsogreg
reviewed
Mar 22, 2023
| @@ -1654,7 +1654,7 @@ prettyTerm ty = \case | |||
| MkPactGuard name -> parensSep ["create-pact-guard", pretty name] | |||
| MkUserGuard g t -> parensSep ["create-user-guard", pretty g, pretty t] | |||
| MkModuleGuard name -> parensSep ["create-module-guard", pretty name] | |||
| MkCapabilityGuard (Capability _ n) as isPact -> parensSep | |||
| MkCapabilityGuard (Capability _ n _) as isPact -> parensSep | |||
There was a problem hiding this comment.
Does CapAnnot not want to be included in the pretty-printed Capability?
There was a problem hiding this comment.
If a cap is @managed or @event makes no difference here. I think the name should be enough. @jmcardon what do you think?
There was a problem hiding this comment.
I think a cap being managed should display somehow. Event is something that will someday be replaced by defevent, I believe.
imalsogreg
reviewed
Mar 22, 2023
imalsogreg
approved these changes
Mar 23, 2023
jwiegley
reviewed
Mar 23, 2023
jwiegley
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.