Pact Aeson2 #1242
Merged
Pact Aeson2 #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
reviewed
Jul 10, 2023
|
Resolved my comments cuz we got |
jmcardon
commented
Jul 13, 2023
| -- on chain 0 at block height 1720161 (txid 2475483). So, we would have | ||
| -- to do this in a fork. | ||
| denom :: UTCTime -> Integer | ||
| denom = denominator . (% 1000) . fromIntegral . toPosixTimestampMicros |
There was a problem hiding this comment.
Note: still needs fixing.
src/Pact/Types/KeySet.hs
Outdated
| @@ -131,6 +136,10 @@ instance Arbitrary KeySet where | |||
| -- | allow `{ "keys": [...], "pred": "..." }`, `{ "keys": [...] }`, and just `[...]`, | |||
| -- | the latter cases defaulting to "keys-all" | |||
| instance FromJSON KeySet where | |||
|
|
|||
| -- Aeson failures: | |||
| -- aeson-1: "read-keyset: parse failed: parsing [] failed, expected Array, but encountered Object: {\"pred\": \"\" ,\"keys\":\n[\"48acfef8d60e90a7c3675cbe7cb4162c15b80d196a5586962cb8a789f1c79fe2\"]}" | |||
There was a problem hiding this comment.
Need to follow up on this as well
jmcardon
commented
Jul 13, 2023
jmcardon
commented
Jul 14, 2023
| (TNative n _fn tys _exs d tl i) -> J.object | ||
| [ prop TermNatFunTypes J..= J.Array tys | ||
| , prop TermName J..= n | ||
| , prop TermFun J..= J.null {- TODO fn -} |
There was a problem hiding this comment.
Not Todo, this is just unlawful and doesn't serialize.
edmundnoble
approved these changes
Jul 18, 2023
emilypi
approved these changes
Jul 18, 2023
sirlensalot
approved these changes
Jul 18, 2023
| instance ToJSON FullyQualifiedName where | ||
| toJSON (FullyQualifiedName n (ModuleName m ns) hsh) = | ||
| toJSON $ maybe "" ((<> ".") . _namespaceName) ns <> m <> "." <> n <> ".{" <> hashToText hsh <> "}" | ||
| fqdnJsonText :: FullyQualifiedName -> T.Text |
There was a problem hiding this comment.
minor nit, not sure why this is toplevel, only used once
There was a problem hiding this comment.
Will fix in followup PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: