From 9b470dccc6a7027b7cba73f4e76dde1ddb405d2c Mon Sep 17 00:00:00 2001 From: Tom Morelly Date: Mon, 25 Aug 2025 14:25:51 +1000 Subject: [PATCH] fix(install): do not add --set for an empty string Signed-off-by: Tom Morelly --- go/cli/internal/cli/install.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/go/cli/internal/cli/install.go b/go/cli/internal/cli/install.go index 8d05804e4..d48aab5e4 100644 --- a/go/cli/internal/cli/install.go +++ b/go/cli/internal/cli/install.go @@ -35,7 +35,9 @@ func installChart(ctx context.Context, chartName string, namespace string, regis // Add set values if any for _, setValue := range setValues { - args = append(args, "--set", setValue) + if setValue != "" { + args = append(args, "--set", setValue) + } } cmd := exec.CommandContext(ctx, "helm", args...) @@ -45,8 +47,7 @@ func installChart(ctx context.Context, chartName string, namespace string, regis return "", nil } -func InstallCmd(ctx context.Context, cfg *config.Config) *PortForward { - +func InstallCmd(ctx context.Context, cfg *config.Config) *PortForward { if version.Version == "dev" { fmt.Fprintln(os.Stderr, "Installation requires released version of kagent") return nil