Skip to content

Commit

Permalink
Merge pull request #898 from kakao/rm_buffer_pool_use
Browse files Browse the repository at this point in the history
chore: remove use of gRPC buffer pool
  • Loading branch information
ijsong authored Oct 23, 2024
2 parents 685587a + 4040dac commit f4eede8
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 71 deletions.
6 changes: 1 addition & 5 deletions internal/benchmark/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ import (

"go.uber.org/multierr"
"golang.org/x/sync/errgroup"
"google.golang.org/grpc"
"google.golang.org/grpc/experimental"

"github.com/kakao/varlog/pkg/types"
"github.com/kakao/varlog/pkg/varlog"
Expand Down Expand Up @@ -56,9 +54,7 @@ func NewLoader(cfg loaderConfig) (loader *Loader, err error) {
if scli != nil {
return scli, nil
}
cli, err := varlog.Open(context.TODO(), loader.cid, loader.mraddrs, varlog.WithGRPCDialOptions(
experimental.WithRecvBufferPool(grpc.NewSharedBufferPool()),
))
cli, err := varlog.Open(context.TODO(), loader.cid, loader.mraddrs)
if err != nil {
return nil, err
}
Expand Down
65 changes: 0 additions & 65 deletions vendor/google.golang.org/grpc/experimental/experimental.go

This file was deleted.

1 change: 0 additions & 1 deletion vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,6 @@ google.golang.org/grpc/credentials/insecure
google.golang.org/grpc/encoding
google.golang.org/grpc/encoding/gzip
google.golang.org/grpc/encoding/proto
google.golang.org/grpc/experimental
google.golang.org/grpc/grpclog
google.golang.org/grpc/health
google.golang.org/grpc/health/grpc_health_v1
Expand Down

0 comments on commit f4eede8

Please sign in to comment.